public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* [PATCH/committed] sim: ppc: phb: add missing break to address decoder
@ 2023-12-21  6:21 Mike Frysinger
  0 siblings, 0 replies; only message in thread
From: Mike Frysinger @ 2023-12-21  6:21 UTC (permalink / raw)
  To: gdb-patches

I don't know what this emulation does exactly, but it missing a break
statement seems kind of obvious based on the 32-bit case above it.
---
 sim/ppc/hw_phb.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sim/ppc/hw_phb.c b/sim/ppc/hw_phb.c
index ec1119ee7d9b..06eb29fc5a77 100644
--- a/sim/ppc/hw_phb.c
+++ b/sim/ppc/hw_phb.c
@@ -652,6 +652,7 @@ hw_phb_unit_decode(device *me,
 	     && val != 0x10 && val != 0x18 && val != 0x20)
       device_error(me, "Register number (0x%lx) invalid in 64bit PCI address %s",
 		   val, unit);
+    break;
   case ss_config_code:
     device_error(me, "internal error");
   }
-- 
2.43.0


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-12-21  6:21 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-21  6:21 [PATCH/committed] sim: ppc: phb: add missing break to address decoder Mike Frysinger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).