public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] gdbserver: require_running_or_break for the 'z' packet
@ 2024-02-29 15:35 Tankut Baris Aktemur
  2024-04-02  8:52 ` Aktemur, Tankut Baris
  0 siblings, 1 reply; 2+ messages in thread
From: Tankut Baris Aktemur @ 2024-02-29 15:35 UTC (permalink / raw)
  To: gdb-patches

Similar to several other packages that access/modify process state,
the 'z' and 'Z' packets need to access the process.  Hence, add a
`require_running_or_break` as a pre-check.
---
 gdbserver/server.cc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gdbserver/server.cc b/gdbserver/server.cc
index 74c7763d777..8b9c4df50ae 100644
--- a/gdbserver/server.cc
+++ b/gdbserver/server.cc
@@ -4731,6 +4731,7 @@ process_serial_event (void)
       /* Fallthrough.  */
     case 'z':  /* remove_ ... */
       {
+	require_running_or_break (cs.own_buf);
 	char *dataptr;
 	ULONGEST addr;
 	int kind;
-- 
2.34.1

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928


^ permalink raw reply	[flat|nested] 2+ messages in thread

* RE: [PATCH] gdbserver: require_running_or_break for the 'z' packet
  2024-02-29 15:35 [PATCH] gdbserver: require_running_or_break for the 'z' packet Tankut Baris Aktemur
@ 2024-04-02  8:52 ` Aktemur, Tankut Baris
  0 siblings, 0 replies; 2+ messages in thread
From: Aktemur, Tankut Baris @ 2024-04-02  8:52 UTC (permalink / raw)
  To: gdb-patches

Kindly pinging.

Thanks.
-Baris

On Thursday, February 29, 2024 4:36 PM, Aktemur, Tankut Baris wrote:
> Similar to several other packages that access/modify process state,
> the 'z' and 'Z' packets need to access the process.  Hence, add a
> `require_running_or_break` as a pre-check.
> ---
>  gdbserver/server.cc | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/gdbserver/server.cc b/gdbserver/server.cc
> index 74c7763d777..8b9c4df50ae 100644
> --- a/gdbserver/server.cc
> +++ b/gdbserver/server.cc
> @@ -4731,6 +4731,7 @@ process_serial_event (void)
>        /* Fallthrough.  */
>      case 'z':  /* remove_ ... */
>        {
> +	require_running_or_break (cs.own_buf);
>  	char *dataptr;
>  	ULONGEST addr;
>  	int kind;
> --
> 2.34.1

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-04-02  8:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-29 15:35 [PATCH] gdbserver: require_running_or_break for the 'z' packet Tankut Baris Aktemur
2024-04-02  8:52 ` Aktemur, Tankut Baris

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).