From: Lancelot SIX <lancelot.six@amd.com>
To: Guinevere Larsen <blarsen@redhat.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH 3/4] gdb: Migrate frame unwinders to use C++ classes
Date: Thu, 7 Mar 2024 11:01:33 +0000 [thread overview]
Message-ID: <20240307110133.lhu7kcqvmqnxmmw2@khazad-dum> (raw)
In-Reply-To: <20240306125135.766567-4-blarsen@redhat.com>
On Wed, Mar 06, 2024 at 01:51:34PM +0100, Guinevere Larsen wrote:
Hi Gwen,
I have not read the specific of this series, but testing the patches as
is causes a build failure on amdgpu-tdep.c
> diff --git a/gdb/amdgpu-tdep.c b/gdb/amdgpu-tdep.c
> index 8189de8e565..45c83a562e8 100644
> --- a/gdb/amdgpu-tdep.c
> +++ b/gdb/amdgpu-tdep.c
> @@ -892,7 +892,7 @@ amdgpu_frame_prev_register (const frame_info_ptr &this_frame, void **this_cache,
> return frame_unwind_got_register (this_frame, regnum, regnum);
> }
>
> -static const frame_unwind amdgpu_frame_unwind = {
> +static const frame_unwind_legacy amdgpu_frame_unwind (
> "amdgpu",
> NORMAL_FRAME,
> FRAME_UNWIND_ARCH,
> @@ -903,7 +903,7 @@ static const frame_unwind amdgpu_frame_unwind = {
> default_frame_sniffer,
> nullptr,
> nullptr,
^
Moving from the aggregate initializer to a regular constructor call,
this last coma must be removed.
With this fixed, I tested this series on the gdb.rocm/*.exp part (both
on upstream GDB and our downstream port) and see no regression.
I'll try to actually read the actual later.
Best,
Lancelot.
> -};
> +);
>
> static int
> print_insn_amdgpu (bfd_vma memaddr, struct disassemble_info *info)
>
> --
> 2.43.2
>
next prev parent reply other threads:[~2024-03-07 11:01 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 12:51 [PATCH 0/4] Modernize frame unwinders and add disable feature Guinevere Larsen
2024-03-06 12:51 ` [PATCH 1/4] gdb: make gdbarch store a vector of frame unwinders Guinevere Larsen
2024-03-08 16:34 ` Tom Tromey
2024-03-11 10:51 ` Guinevere Larsen
2024-03-11 18:01 ` Tom Tromey
2024-03-06 12:51 ` [PATCH 2/4] gdb: add "unwinder class" to " Guinevere Larsen
2024-03-08 16:40 ` Tom Tromey
2024-03-06 12:51 ` [PATCH 3/4] gdb: Migrate frame unwinders to use C++ classes Guinevere Larsen
2024-03-07 11:01 ` Lancelot SIX [this message]
2024-03-07 11:04 ` Guinevere Larsen
2024-03-08 17:07 ` Tom Tromey
2024-03-12 16:24 ` Guinevere Larsen
2024-03-06 12:51 ` [PATCH 4/4] GDB: introduce ability to disable frame unwinders Guinevere Larsen
2024-03-06 13:47 ` Eli Zaretskii
2024-03-06 14:07 ` Guinevere Larsen
2024-03-06 14:16 ` Eli Zaretskii
2024-03-08 17:22 ` Tom Tromey
2024-03-11 14:09 ` Guinevere Larsen
2024-03-11 14:56 ` [PATCH 0/4] Modernize frame unwinders and add disable feature Luis Machado
2024-03-11 15:00 ` Guinevere Larsen
2024-03-11 15:10 ` Luis Machado
2024-03-13 12:08 ` Guinevere Larsen
2024-03-13 12:44 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240307110133.lhu7kcqvmqnxmmw2@khazad-dum \
--to=lancelot.six@amd.com \
--cc=blarsen@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).