From: Eli Zaretskii <eliz@gnu.org>
To: Guinevere Larsen <blarsen@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 4/4] GDB: introduce ability to disable frame unwinders
Date: Wed, 06 Mar 2024 16:16:23 +0200 [thread overview]
Message-ID: <86y1avjvig.fsf@gnu.org> (raw)
In-Reply-To: <5760021d-9de3-492d-af65-225e61971901@redhat.com> (message from Guinevere Larsen on Wed, 6 Mar 2024 15:07:17 +0100)
> Date: Wed, 6 Mar 2024 15:07:17 +0100
> Cc: gdb-patches@sourceware.org
> From: Guinevere Larsen <blarsen@redhat.com>
>
> >> +The meaning of the argument @samp{unwinder} depends on the @samp{option}
> > The correct markup here is @var, not @samp, since these are not
> > literal symbols, but instead names of parameters that stand for
> > something else. Likewise elsewhere in the gdb.texinfo part of the
> > patch.
>
> Ah, thanks for explaining! Should I also change the @samp in the table
> section?
Only for @samp{unwinder} and @samp{option}. The rest are literals,
like "-all".
> >> +The class may include the prefix @code{FRAME_UNWINDER_}, but it is not
> >> +required. This is the default option.
> > What do you mean by the last sentence? What is "this" that is the
> > default option? And what does "default" mean for an option, since an
> > option is by definition something that doesn't happen by default.
>
> option is an optional parameter, and if the user decides to not provide
> it, the command will work as if the user had provided the -class option.
Then I suggest to rephrase like this:
By default, @var{unwinder} is interpreted as a class, even if
@samp{-class} was omitted.
next prev parent reply other threads:[~2024-03-06 14:16 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 12:51 [PATCH 0/4] Modernize frame unwinders and add disable feature Guinevere Larsen
2024-03-06 12:51 ` [PATCH 1/4] gdb: make gdbarch store a vector of frame unwinders Guinevere Larsen
2024-03-08 16:34 ` Tom Tromey
2024-03-11 10:51 ` Guinevere Larsen
2024-03-11 18:01 ` Tom Tromey
2024-03-06 12:51 ` [PATCH 2/4] gdb: add "unwinder class" to " Guinevere Larsen
2024-03-08 16:40 ` Tom Tromey
2024-03-06 12:51 ` [PATCH 3/4] gdb: Migrate frame unwinders to use C++ classes Guinevere Larsen
2024-03-07 11:01 ` Lancelot SIX
2024-03-07 11:04 ` Guinevere Larsen
2024-03-08 17:07 ` Tom Tromey
2024-03-12 16:24 ` Guinevere Larsen
2024-03-06 12:51 ` [PATCH 4/4] GDB: introduce ability to disable frame unwinders Guinevere Larsen
2024-03-06 13:47 ` Eli Zaretskii
2024-03-06 14:07 ` Guinevere Larsen
2024-03-06 14:16 ` Eli Zaretskii [this message]
2024-03-08 17:22 ` Tom Tromey
2024-03-11 14:09 ` Guinevere Larsen
2024-03-11 14:56 ` [PATCH 0/4] Modernize frame unwinders and add disable feature Luis Machado
2024-03-11 15:00 ` Guinevere Larsen
2024-03-11 15:10 ` Luis Machado
2024-03-13 12:08 ` Guinevere Larsen
2024-03-13 12:44 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86y1avjvig.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=blarsen@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).