From: Luis Machado <luis.machado@arm.com>
To: Guinevere Larsen <blarsen@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 0/4] Modernize frame unwinders and add disable feature
Date: Mon, 11 Mar 2024 15:10:19 +0000 [thread overview]
Message-ID: <49325cdf-f64c-404d-9b7a-54a820b00ca4@arm.com> (raw)
In-Reply-To: <2702cb98-2bc0-40fb-a871-a10aa1aeb0f7@redhat.com>
On 3/11/24 15:00, Guinevere Larsen wrote:
> On 11/03/2024 15:56, Luis Machado wrote:
>> Hi,
>>
>> On 3/6/24 12:51, Guinevere Larsen wrote:
>>> This patch series started with me trying to make it easier to test GDB's
>>> ability to unwind using CFI data, to improve a previous patch I sent to
>>> the list. However, once I finished these changes, I realized there was
>>> an unrelated bug I should fix before proposing the CFI test. Since these
>>> changes are significant enough already, and I think would be interesting
>>> on their own, I figured I shoudl submit this patch series as is right
>>> now while I figure out the other bug.
>>>
>>> The first patch is just a minor change, storing frame unwinders in a
>>> vector instead of through an unwinder table accessible using the
>>> registry system. This isn't required (like I originally thought it was),
>>> but it does make the whole system more readable in my opinion.
>>>
>>> Patch 3 has the real meat of the modernization, making GDB use
>>> polymorphism to handle frame unwinders. This is slightly slower than
>>> using function pointers, but much more readable in my opinion.
>>>
>>> As for the unwinder classes, they were chosen somewhat arbitrarily,
>>> mostly based on where I found an unwinder and its name. I almost expect
>>> some unwinders to be mis-categorized, but that should be easy to fix.
>>>
>>> The changes up to patch 3 have been tested with a try-branch, no
>>> regressions as far as I could see.
>>>
>>> Guinevere Larsen (4):
>>> gdb: make gdbarch store a vector of frame unwinders
>>> gdb: add "unwinder class" to frame unwinders
>>> gdb: Migrate frame unwinders to use C++ classes
>>> GDB: introduce ability to disable frame unwinders
>> I haven't gone through the series in detail, but I thought I'd give it a try on one of the
>> aarch64 machines I have access to. I didn't look particularly healthy:
>>
>>
>> # of unexpected core files 47
>> # of expected passes 116521
>> # of unexpected failures 581
>> # of expected failures 77
>> # of known failures 116
>> # of untested testcases 128
>> # of unresolved testcases 1102
>> # of unsupported tests 458
>> # of duplicate test names 10
>>
>> I see a number of internal errors going on. Mostly like these:
>>
>> ../../../repos/binutils-gdb/gdbsupport/errors.cc:58
>> 0xaaaad27e7877 check_ptrace_stopped_lwp_gone
>> ../../../repos/binutils-gdb/gdb/linux-nat.c:1634
>> 0xaaaad27e7877 check_ptrace_stopped_lwp_gone
>> ../../../repos/binutils-gdb/gdb/linux-nat.c:1630
>> 0xaaaad2ae0fa3 linux_resume_one_lwp
>>
> Oh no! Linaro CI had showed something was wrong, but I wasn't able to grab an aarch64 machine to test yet. I'll check it out when I can, thanks for narrowing it down for me
>
You're welcome. Do let me know if you can't easily find an aarch64 machine to try things on, and I can provide more info
and take a deeper look.
next prev parent reply other threads:[~2024-03-11 15:10 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 12:51 Guinevere Larsen
2024-03-06 12:51 ` [PATCH 1/4] gdb: make gdbarch store a vector of frame unwinders Guinevere Larsen
2024-03-08 16:34 ` Tom Tromey
2024-03-11 10:51 ` Guinevere Larsen
2024-03-11 18:01 ` Tom Tromey
2024-03-06 12:51 ` [PATCH 2/4] gdb: add "unwinder class" to " Guinevere Larsen
2024-03-08 16:40 ` Tom Tromey
2024-03-06 12:51 ` [PATCH 3/4] gdb: Migrate frame unwinders to use C++ classes Guinevere Larsen
2024-03-07 11:01 ` Lancelot SIX
2024-03-07 11:04 ` Guinevere Larsen
2024-03-08 17:07 ` Tom Tromey
2024-03-12 16:24 ` Guinevere Larsen
2024-03-06 12:51 ` [PATCH 4/4] GDB: introduce ability to disable frame unwinders Guinevere Larsen
2024-03-06 13:47 ` Eli Zaretskii
2024-03-06 14:07 ` Guinevere Larsen
2024-03-06 14:16 ` Eli Zaretskii
2024-03-08 17:22 ` Tom Tromey
2024-03-11 14:09 ` Guinevere Larsen
2024-03-11 14:56 ` [PATCH 0/4] Modernize frame unwinders and add disable feature Luis Machado
2024-03-11 15:00 ` Guinevere Larsen
2024-03-11 15:10 ` Luis Machado [this message]
2024-03-13 12:08 ` Guinevere Larsen
2024-03-13 12:44 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49325cdf-f64c-404d-9b7a-54a820b00ca4@arm.com \
--to=luis.machado@arm.com \
--cc=blarsen@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).