public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Thiago Jung Bauermann <thiago.bauermann@linaro.org>
To: gdb-patches@sourceware.org
Cc: Christophe Lyon <christophe.lyon@linaro.org>,
	Luis Machado <luis.machado@arm.com>,
	Pedro Alves <pedro@palves.net>
Subject: [PATCH v2 0/3] Fix attaching to process when it has zombie threads
Date: Sat, 20 Apr 2024 02:56:49 -0300	[thread overview]
Message-ID: <20240420055652.819024-1-thiago.bauermann@linaro.org> (raw)

Hello,

Thank you for your review of the patches! This version incorporates the
comments.

Luis suggested adding macros to identify the field indexes in
/proc/PID/stat, but Pedro doesn't think they help. I personally think they
help, but I agree that not by that much, so I don't have a strong opinion.

Since the previous version didn't have the macros, I'm sending v2 with
them so that it's easy to compare both and decide. I can remove the
macros if they're deemed unnecessary.

v1 of this series is here:

https://inbox.sourceware.org/gdb-patches/20240321231149.519549-1-thiago.bauermann@linaro.org/

Thiago Jung Bauermann (3):
  gdb/nat: Use procfs(5) indexes in linux_common_core_of_thread
  gdb/nat: Factor linux_proc_get_stat_field out of
    linux_common_core_of_thread
  gdb/nat/linux: Fix attaching to process when it has zombie threads

 gdb/nat/linux-osdata.c | 38 +++--------------
 gdb/nat/linux-osdata.h |  3 ++
 gdb/nat/linux-procfs.c | 96 ++++++++++++++++++++++++++++++++++++++++++
 gdb/nat/linux-procfs.h | 11 +++++
 4 files changed, 115 insertions(+), 33 deletions(-)


base-commit: edc27e2d90a2af3afddd68e7a534afcc428719e5

             reply	other threads:[~2024-04-20  5:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-20  5:56 Thiago Jung Bauermann [this message]
2024-04-20  5:56 ` [PATCH v2 1/3] gdb/nat: Use procfs(5) indexes in linux_common_core_of_thread Thiago Jung Bauermann
2024-04-22 19:39   ` Pedro Alves
2024-04-24 23:09     ` Thiago Jung Bauermann
2024-04-20  5:56 ` [PATCH v2 2/3] gdb/nat: Factor linux_proc_get_stat_field out of linux_common_core_of_thread Thiago Jung Bauermann
2024-04-20  5:56 ` [PATCH v2 3/3] gdb/nat/linux: Fix attaching to process when it has zombie threads Thiago Jung Bauermann
2024-04-22 19:59   ` Pedro Alves
2024-04-24 23:15     ` Thiago Jung Bauermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240420055652.819024-1-thiago.bauermann@linaro.org \
    --to=thiago.bauermann@linaro.org \
    --cc=christophe.lyon@linaro.org \
    --cc=gdb-patches@sourceware.org \
    --cc=luis.machado@arm.com \
    --cc=pedro@palves.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).