From: Tom de Vries <tdevries@suse.de>
To: Mark Wielaard <mark@klomp.org>
Cc: gdb-patches@sourceware.org, Kevin Buettner <kevinb@redhat.com>
Subject: Re: [PATCH][gdb] Fix python selftest with python 3.11
Date: Thu, 21 Jul 2022 14:55:30 +0200 [thread overview]
Message-ID: <262ad25a-f86d-628b-50b5-17a2c0131fd1@suse.de> (raw)
In-Reply-To: <YtlIR6mkhmghbhBs@wildebeest.org>
[-- Attachment #1: Type: text/plain, Size: 890 bytes --]
On 7/21/22 14:36, Mark Wielaard wrote:
> Hi Tom,
>
> On Thu, Jul 21, 2022 at 02:06:09PM +0200, Tom de Vries wrote:
>>> It seems the line number is really irrelevant here for where exactly
>>> the KeyboardInterrupt took place. So the patch looks good to me.
>>>
>>
>> Thanks for the review.
>>
>>> Note that there is a gdb-try-rawhide-x86_64 builder, so you can also
>>> test by pushing this to a git users/vries/try-xxx branch.
>>
>> I've tried that, and it went fine, so I've pushed this (after fixing a
>> trivial formatting issue, not reposting).
>
> I am afraid the trivial formatting fix accidentially introduced an
> extra space before KeyboardInterrupt:
>
> " KeyboardInterrupt\n" should be "KeyboardInterrupt\n"
>
Thanks for noticing that.
Fixed by this commit (also tested using the try-buildbot, and this time,
committed what I actually tested).
Committed.
Thanks,
- Tom
[-- Attachment #2: 0001-gdb-python-Fix-typo-in-test_python.patch --]
[-- Type: text/x-patch, Size: 803 bytes --]
[gdb/python] Fix typo in test_python
Fix typo in ref_output_0 variable in test_python.
Tested by running the selftest on x86_64-linux with python 3.11.
---
gdb/python/python.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/python/python.c b/gdb/python/python.c
index c0312413a73..c7d4157b70c 100644
--- a/gdb/python/python.c
+++ b/gdb/python/python.c
@@ -2242,7 +2242,7 @@ test_python ()
SELF_CHECK (saw_exception);
std::string ref_output_0 ("Traceback (most recent call last):\n"
" File \"<string>\", line 0, in <module>\n"
- " KeyboardInterrupt\n");
+ "KeyboardInterrupt\n");
std::string ref_output_1 ("Traceback (most recent call last):\n"
" File \"<string>\", line 1, in <module>\n"
"KeyboardInterrupt\n");
prev parent reply other threads:[~2022-07-21 12:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-21 11:13 Tom de Vries
2022-07-21 11:42 ` Mark Wielaard
2022-07-21 12:06 ` Tom de Vries
2022-07-21 12:36 ` Mark Wielaard
2022-07-21 12:55 ` Tom de Vries [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=262ad25a-f86d-628b-50b5-17a2c0131fd1@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
--cc=mark@klomp.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).