From: Mark Wielaard <mark@klomp.org>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org, Kevin Buettner <kevinb@redhat.com>
Subject: Re: [PATCH][gdb] Fix python selftest with python 3.11
Date: Thu, 21 Jul 2022 14:36:23 +0200 [thread overview]
Message-ID: <YtlIR6mkhmghbhBs@wildebeest.org> (raw)
In-Reply-To: <716feba4-7ca1-dc46-12b3-e7a895956d8b@suse.de>
Hi Tom,
On Thu, Jul 21, 2022 at 02:06:09PM +0200, Tom de Vries wrote:
> > It seems the line number is really irrelevant here for where exactly
> > the KeyboardInterrupt took place. So the patch looks good to me.
> >
>
> Thanks for the review.
>
> > Note that there is a gdb-try-rawhide-x86_64 builder, so you can also
> > test by pushing this to a git users/vries/try-xxx branch.
>
> I've tried that, and it went fine, so I've pushed this (after fixing a
> trivial formatting issue, not reposting).
I am afraid the trivial formatting fix accidentially introduced an
extra space before KeyboardInterrupt:
" KeyboardInterrupt\n" should be "KeyboardInterrupt\n"
Cheers,
Mark
next prev parent reply other threads:[~2022-07-21 12:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-21 11:13 Tom de Vries
2022-07-21 11:42 ` Mark Wielaard
2022-07-21 12:06 ` Tom de Vries
2022-07-21 12:36 ` Mark Wielaard [this message]
2022-07-21 12:55 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtlIR6mkhmghbhBs@wildebeest.org \
--to=mark@klomp.org \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).