Re: [PATCH] Fix gdb/coffread.c build on 32bit architectures

[Mark Wielaard <mark@klomp.org>]

[-- Attachment #1: Type: text/plain, Size: 730 bytes --]

On Mon, 2023-08-28 at 08:08 -0600, Tom Tromey wrote:
> > > > > > "Mark" == Mark Wielaard <mark@klomp.org> writes:
> 
> Hi Mark.  Thanks for the patch.
> 
> Mark> +	error (_("COFF Error: string table offset (%" PRIxPTR ") outside string table (length %ld)"),
> 
> gdb doesn't use these PRI macros.

Not always, but there are various uses in the code base.
e.g. gdb/dwarf2/cooked-index.c uses
gdb_printf ("    DIE offset: 0x%" PRIx64 "\n", ...
As do gdb/bt-utils.c, gdb/btrace.c, gdb/netbsd-nat.c.
And bfd, opcodes, sim, etc. do use it.

>   Instead you'd write something like:
> 
>     error ("...%s...", hex_string (value))

OK, the attached seems to work on both 32 and 64 bit systems.

Cheers,

Mark

[-- Attachment #2: 0001-Use-hex_string-in-gdb-coffread.c-instead-of-PRIxPTR.patch --]
[-- Type: text/x-patch, Size: 1123 bytes --]

From 3aaddda2c6e3679579c455e7a71981ffe1724206 Mon Sep 17 00:00:00 2001
From: Mark Wielaard <mark@klomp.org>
Date: Mon, 28 Aug 2023 16:30:14 +0200
Subject: [PATCH] Use hex_string in gdb/coffread.c instead of PRIxPTR

The getsymname function uses PRIxPTR to print and uintptr_t value in
an error message. Use hex_string instead.
---
 gdb/coffread.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gdb/coffread.c b/gdb/coffread.c
index c609c963453..c2fe9fa1761 100644
--- a/gdb/coffread.c
+++ b/gdb/coffread.c
@@ -1325,8 +1325,8 @@ getsymname (struct internal_syment *symbol_entry)
   if (symbol_entry->_n._n_n._n_zeroes == 0)
     {
       if (symbol_entry->_n._n_n._n_offset > stringtab_length)
-	error (_("COFF Error: string table offset (%" PRIxPTR ") outside string table (length %ld)"),
-	       symbol_entry->_n._n_n._n_offset, stringtab_length);
+	error (_("COFF Error: string table offset (%s) outside string table (length %ld)"),
+	       hex_string (symbol_entry->_n._n_n._n_offset), stringtab_length);
       result = stringtab + symbol_entry->_n._n_n._n_offset;
     }
   else
-- 
2.41.0