Re: [PATCH] Fix gdb/coffread.c build on 32bit architectures

[Keith Seitz <keiths@redhat.com>]

On 8/28/23 07:20, Keith Seitz via Gdb-patches wrote:
> 
> May I assume that converting to hex_string for printing these offsets is obvious
> or pre-approved?

Or to be more explicit (pardon me -- ECAFFEINE):

Use hex_string to output hexidecimal values

Late last week, I committed a patch that used %ld to output the
value of some offsets in coffread.c.  This caused a build failure
on 32-bit hardware, and Mark Wielaard offered up a quick fix by
using PRIxPTR.

As mentioned by Tom Tromey, the correct way to handle this is by using
a utility function such as hex_string.  This patch converts the two
%ld formats into %s w/hex_string instead.
---
  gdb/coffread.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gdb/coffread.c b/gdb/coffread.c
index c609c963453..3caa7eb3175 100644
--- a/gdb/coffread.c
+++ b/gdb/coffread.c
@@ -1325,8 +1325,8 @@ getsymname (struct internal_syment *symbol_entry)
    if (symbol_entry->_n._n_n._n_zeroes == 0)
      {
        if (symbol_entry->_n._n_n._n_offset > stringtab_length)
-	error (_("COFF Error: string table offset (%" PRIxPTR ") outside string table (length %ld)"),
-	       symbol_entry->_n._n_n._n_offset, stringtab_length);
+	error (_("COFF Error: string table offset (%s) outside string table (length %s)"),
+	       hex_string (symbol_entry->_n._n_n._n_offset), hex_string (stringtab_length));
        result = stringtab + symbol_entry->_n._n_n._n_offset;
      }
    else
-- 
2.41.0