From: Mark Wielaard <mark@klomp.org>
To: gdb-patches@sourceware.org
Cc: Keith Seitz <keiths@redhat.com>, Mark Wielaard <mark@klomp.org>
Subject: [PATCH] Fix gdb/coffread.c build on 32bit architectures
Date: Fri, 25 Aug 2023 23:16:53 +0200 [thread overview]
Message-ID: <20230825211653.2097671-1-mark@klomp.org> (raw)
In-Reply-To: <3b0896a6-04d4-4c7c-ac32-9ae78acdb66c@redhat.com/>
The getsymname function tries to emit an error using %ld for an
uintptr_t argument. Use PRIxPTR instead. Which works on any architecture
for uintptr_t.
---
gdb/coffread.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/coffread.c b/gdb/coffread.c
index ae7632d49cb..c609c963453 100644
--- a/gdb/coffread.c
+++ b/gdb/coffread.c
@@ -1325,7 +1325,7 @@ getsymname (struct internal_syment *symbol_entry)
if (symbol_entry->_n._n_n._n_zeroes == 0)
{
if (symbol_entry->_n._n_n._n_offset > stringtab_length)
- error (_("COFF Error: string table offset (%ld) outside string table (length %ld)"),
+ error (_("COFF Error: string table offset (%" PRIxPTR ") outside string table (length %ld)"),
symbol_entry->_n._n_n._n_offset, stringtab_length);
result = stringtab + symbol_entry->_n._n_n._n_offset;
}
--
2.39.3
next parent reply other threads:[~2023-08-25 21:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <3b0896a6-04d4-4c7c-ac32-9ae78acdb66c@redhat.com/>
2023-08-25 21:16 ` Mark Wielaard [this message]
2023-08-25 21:19 ` Keith Seitz
2023-08-28 14:08 ` Tom Tromey
2023-08-28 14:20 ` Keith Seitz
2023-08-28 14:27 ` Keith Seitz
2023-08-28 14:32 ` Mark Wielaard
2023-08-28 14:41 ` Andreas Schwab
2023-08-28 16:31 ` Tom Tromey
2023-08-28 16:33 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230825211653.2097671-1-mark@klomp.org \
--to=mark@klomp.org \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).