Re: [PATCH v2] Ensure index cache entry written in test

[Simon Marchi <simark@simark.ca>]

On 3/7/23 09:58, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
> 
>>> +	gdb_test_no_output "maintenance wait-for-index-cache"
> 
> Simon> I would perhaps put this command in the run_test_with_flags proc, so
> Simon> that it applies to other tests as well.  It shouldn't be necessary for
> Simon> those tests, but if there's a bug somewhere, it would make it reproduce
> Simon> more reliably.
> 
> I made this change.  It required the appended hunk as well, to avoid a
> duplicate test name.
> 
> I'm going to check it in now.

Heh, we get that now:

(gdb) maintenance selftest help
Running selftest help_doc_invariants.
help doc broken invariant: command 'maintenance wait-for-index-cache' help doc first line is not terminated with a '.' character
Self test failed: self-test failed at /home/simark/src/binutils-gdb/gdb/unittests/command-def-selftests.c:99
Ran 1 unit tests, 1 failed

I guess swap the lines?  That's how other commands do it:

    Print value of expression EXP.
    Usage: print [[OPTION]... --] [/FMT] [EXP]

    Print backtrace of all stack frames, or innermost COUNT frames.
    Usage: backtrace [OPTION]... [QUALIFIER]... [COUNT | -COUNT]

Simon