From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v2] Ensure index cache entry written in test
Date: Mon, 6 Mar 2023 12:59:00 -0500 [thread overview]
Message-ID: <fc58568d-6264-cb03-02d6-183db355c0f7@simark.ca> (raw)
In-Reply-To: <20230306164553.1449009-1-tromey@adacore.com>
> diff --git a/gdb/testsuite/gdb.base/index-cache.exp b/gdb/testsuite/gdb.base/index-cache.exp
> index 0614d4ee2db..7fdf90c2c24 100644
> --- a/gdb/testsuite/gdb.base/index-cache.exp
> +++ b/gdb/testsuite/gdb.base/index-cache.exp
> @@ -159,6 +159,8 @@ proc_with_prefix test_cache_enabled_miss { cache_dir } {
>
> run_test_with_flags $cache_dir on {
>
> + gdb_test_no_output "maintenance wait-for-index-cache"
I would perhaps put this command in the run_test_with_flags proc, so
that it applies to other tests as well. It shouldn't be necessary for
those tests, but if there's a bug somewhere, it would make it reproduce
more reliably.
Otherwise:
Approved-By: Simon Marchi <simon.marchi@efficios.com>
Simon
next prev parent reply other threads:[~2023-03-06 17:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 16:45 Tom Tromey
2023-03-06 17:59 ` Simon Marchi [this message]
2023-03-07 14:58 ` Tom Tromey
2023-03-07 17:21 ` Simon Marchi
2023-03-07 18:25 ` Tom Tromey
2023-03-09 1:58 ` Simon Marchi
2023-03-24 22:25 ` Tom Tromey
2023-03-06 18:24 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc58568d-6264-cb03-02d6-183db355c0f7@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).