Re: [PATCH v4 09/13] gdb: Use x86_xstate_layout to parse the XSAVE extended state area.

[Simon Marchi <simark@simark.ca>]

I don't know the x86 register set by heart, so this patch is a bit
cryptic for me.  It's a of code that looks similar but not quite, it
would be hard to spot a typo in there.  I didn't spot any mistake, but
that doesn't mean much.

On 3/17/23 21:09, John Baldwin wrote:
> All of the tables describing the offsets of indvidual registers for

individual

> -/* At xsave_avx512_zmm_h_offset[REGNUM] you find the offset to the location in
> -   the upper 256bit of AVX512 ZMMH register data structure used by the "xsave"
> -   instruction where GDB register REGNUM is stored.  */
>  
> -static int xsave_avx512_zmm_h_offset[] =
> +/* At xsave_avx512_zmm0_h_offset[REGNUM] you find the relative offset
> +   within the ZMM_H region of the XSAVE extended state where the upper
> +   256bits of the GDB register ZMM0 + REGNUM is stored.  */
> +
> +/* At xsave_avx512_zmm16_h_offset[REGNUM] you find the relative offset
> +   within the ZMM_H region of the XSAVE extended state where the upper
> +   256bits of the GDB register ZMM16 + REGNUM is stored.  */

I think this second comment is misplaced, and should be just above
xsave_avx512_zmm16_h_offset?

Simon