From: John Baldwin <jhb@FreeBSD.org>
To: Simon Marchi <simark@simark.ca>, gdb-patches@sourceware.org
Subject: Re: [PATCH v4 03/13] nat/x86-cpuid.h: Add x86_cpuid_count wrapper around __get_cpuid_count.
Date: Mon, 10 Apr 2023 13:49:13 -0700 [thread overview]
Message-ID: <be07e94d-cea9-5b14-a513-88fbb952feb5@FreeBSD.org> (raw)
In-Reply-To: <f3295554-3ea3-caee-0896-66eb1fcaa26d@simark.ca>
On 4/6/23 12:33 PM, Simon Marchi wrote:
> On 3/17/23 21:08, John Baldwin wrote:
>> ---
>> gdb/nat/x86-cpuid.h | 27 +++++++++++++++++++++++++++
>> 1 file changed, 27 insertions(+)
>>
>> diff --git a/gdb/nat/x86-cpuid.h b/gdb/nat/x86-cpuid.h
>> index 0955afba577..3ddf6c7b360 100644
>> --- a/gdb/nat/x86-cpuid.h
>> +++ b/gdb/nat/x86-cpuid.h
>> @@ -48,6 +48,25 @@ x86_cpuid (unsigned int __level,
>> return __get_cpuid (__level, __eax, __ebx, __ecx, __edx);
>> }
>>
>> +static __inline int
>> +x86_cpuid_count (unsigned int __level, unsigned int __sublevel,
>> + unsigned int *__eax, unsigned int *__ebx,
>> + unsigned int *__ecx, unsigned int *__edx)
>
> Can you please add a comment?
Yes.
>> +{
>> + unsigned int __scratch;
>> +
>> + if (!__eax)
>> + __eax = &__scratch;
>> + if (!__ebx)
>> + __ebx = &__scratch;
>> + if (!__ecx)
>> + __ecx = &__scratch;
>> + if (!__edx)
>> + __edx = &__scratch;
>
> I know this is a copy of x86_cpuid, but those should use == nullptr.
Fixed.
>> +
>> + return __get_cpuid_count (__level, __sublevel, __eax, __ebx, __ecx, __edx);
>> +}
>> +
>> #else
>>
>> static __inline int
>> @@ -58,6 +77,14 @@ x86_cpuid (unsigned int __level,
>> return 0;
>> }
>>
>> +static __inline int
>> +x86_cpuid_count (unsigned int __level, unsigned int __sublevel,
>> + unsigned int *__eax, unsigned int *__ebx,
>> + unsigned int *__ecx, unsigned int *__edx)
>> +{
>> + return 0;
>> +}
>> +
>> #endif /* i386 && x86_64 */
>
> I'm surprised that we provide fallbacks for these functions when !i386
> and !x86_64. I would think that this file should only be included when
> compiling on i386/x86_64.
I'm also surprised, and a quick grep looks like it should be safe to drop
these to me, but perhaps as a separate followup?
--
John Baldwin
next prev parent reply other threads:[~2023-04-10 20:49 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-18 1:08 [PATCH v4 00/13] Handle variable XSAVE layouts John Baldwin
2023-03-18 1:08 ` [PATCH v4 01/13] x86: Add an x86_xsave_layout structure to handle " John Baldwin
2023-03-28 11:35 ` George, Jini Susan
2023-04-10 19:28 ` John Baldwin
2023-04-06 19:09 ` Simon Marchi
2023-04-10 20:03 ` John Baldwin
2023-04-11 1:19 ` Simon Marchi
2023-04-11 14:23 ` Pedro Alves
2023-04-11 16:02 ` John Baldwin
2023-03-18 1:08 ` [PATCH v4 02/13] core: Support fetching TARGET_OBJECT_X86_XSAVE_LAYOUT from architectures John Baldwin
2023-04-06 19:28 ` Simon Marchi
2023-04-10 20:42 ` John Baldwin
2023-04-11 1:49 ` Simon Marchi
2023-04-11 16:06 ` John Baldwin
2023-04-11 16:21 ` Simon Marchi
2023-04-11 23:59 ` John Baldwin
2023-03-18 1:08 ` [PATCH v4 03/13] nat/x86-cpuid.h: Add x86_cpuid_count wrapper around __get_cpuid_count John Baldwin
2023-04-06 19:33 ` Simon Marchi
2023-04-10 20:49 ` John Baldwin [this message]
2023-04-11 1:49 ` Simon Marchi
2023-03-18 1:08 ` [PATCH v4 04/13] x86 nat: Add helper functions to save the XSAVE layout for the host John Baldwin
2023-04-06 19:40 ` Simon Marchi
2023-04-10 21:00 ` John Baldwin
2023-04-11 1:51 ` Simon Marchi
2023-03-18 1:08 ` [PATCH v4 05/13] gdb: Update x86 FreeBSD architectures to support XSAVE layouts John Baldwin
2023-04-06 19:54 ` Simon Marchi
2023-04-10 21:02 ` John Baldwin
2023-04-11 1:55 ` Simon Marchi
2023-03-18 1:08 ` [PATCH v4 06/13] gdb: Support XSAVE layouts for the current host in the FreeBSD x86 targets John Baldwin
2023-04-06 20:18 ` Simon Marchi
2023-04-10 21:27 ` John Baldwin
2023-04-11 2:23 ` Simon Marchi
2023-04-11 16:19 ` John Baldwin
2023-04-11 16:46 ` Simon Marchi
2023-04-11 21:37 ` John Baldwin
2023-04-11 22:35 ` John Baldwin
2023-04-12 14:35 ` Simon Marchi
2023-03-18 1:08 ` [PATCH v4 07/13] gdb: Update x86 Linux architectures to support XSAVE layouts John Baldwin
2023-04-07 1:43 ` Simon Marchi
2023-04-10 21:29 ` John Baldwin
2023-03-18 1:09 ` [PATCH v4 08/13] gdb: Support XSAVE layouts for the current host in the Linux x86 targets John Baldwin
2023-04-07 1:54 ` Simon Marchi
2023-03-18 1:09 ` [PATCH v4 09/13] gdb: Use x86_xstate_layout to parse the XSAVE extended state area John Baldwin
2023-04-07 2:13 ` Simon Marchi
2023-04-10 21:40 ` John Baldwin
2023-03-18 1:09 ` [PATCH v4 10/13] gdbserver: Add a function to set the XSAVE mask and size John Baldwin
2023-04-12 15:08 ` Simon Marchi
2023-04-27 17:24 ` John Baldwin
2023-03-18 1:09 ` [PATCH v4 11/13] gdbserver: Refactor the legacy region within the xsave struct John Baldwin
2023-04-12 18:34 ` Simon Marchi
2023-04-27 19:51 ` John Baldwin
2023-03-18 1:09 ` [PATCH v4 12/13] gdbserver: Read offsets of the XSAVE extended region via CPUID John Baldwin
2023-04-11 14:46 ` Pedro Alves
2023-04-11 16:25 ` John Baldwin
2023-04-12 19:11 ` Simon Marchi
2023-04-12 21:07 ` John Baldwin
2023-04-13 15:07 ` Simon Marchi
2023-03-18 1:09 ` [PATCH v4 13/13] x86: Remove X86_XSTATE_SIZE and related constants John Baldwin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be07e94d-cea9-5b14-a513-88fbb952feb5@FreeBSD.org \
--to=jhb@freebsd.org \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).