From: Simon Marchi <simark@simark.ca>
To: Lancelot SIX <lancelot.six@amd.com>,
gdb-patches@sourceware.org, simon.marchi@efficios.com
Cc: lsix@lancelotsix.com
Subject: Re: [PATCH 1/1] gdb: Update doc of the "maintenance info line-table"
Date: Wed, 22 Mar 2023 09:59:24 -0400 [thread overview]
Message-ID: <3a38867b-e481-c4be-95db-0058afbaf2b3@simark.ca> (raw)
In-Reply-To: <20230322102642.510635-2-lancelot.six@amd.com>
On 3/22/23 06:26, Lancelot SIX via Gdb-patches wrote:
> Commit 904d9b02a18 (gdb: make "maintenance info line-table" show
> relocated addresses again) have updated the "maintenance info
> line-table" command, but did not update the associated documentation.
>
> This patch updates the documentation to reflect the new command output.
Thanks, I didn't think that a maintenance command would have so much
details in the doc.
> ---
> gdb/doc/gdb.texinfo | 32 +++++++++++++++++++-------------
> 1 file changed, 19 insertions(+), 13 deletions(-)
>
> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
> index 6c811b8be2e..dbb6267f3fd 100644
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -20345,21 +20345,27 @@ objfile: /home/gnu/build/a.out ((struct objfile *) 0x6120000e0d40)
> compunit_symtab: simple.cpp ((struct compunit_symtab *) 0x6210000ff450)
> symtab: /home/gnu/src/simple.cpp ((struct symtab *) 0x6210000ff4d0)
> linetable: ((struct linetable *) 0x62100012b760):
> -INDEX LINE ADDRESS IS-STMT PROLOGUE-END
> -0 3 0x0000000000401110 Y
> -1 4 0x0000000000401114 Y Y
> -2 9 0x0000000000401120 Y
> -3 10 0x0000000000401124 Y Y
> -4 10 0x0000000000401129
> -5 15 0x0000000000401130 Y
> -6 16 0x0000000000401134 Y Y
> -7 16 0x0000000000401139
> -8 21 0x0000000000401140 Y
> -9 22 0x000000000040114f Y Y
> -10 22 0x0000000000401154
> -11 END 0x000000000040115a Y
> +INDEX LINE REL-ADDRESS UNREL-ADDRESS IS-STMT PROLOGUE-END
> +0 3 0x0000555555955110 0x0000000000401110 Y
> +1 4 0x0000555555955114 0x0000000000401114 Y Y
> +2 9 0x0000555555955120 0x0000000000401120 Y
> +3 10 0x0000555555955124 0x0000000000401124 Y Y
> +4 10 0x0000555555955129 0x0000000000401129
> +5 15 0x0000555555955130 0x0000000000401130 Y
> +6 16 0x0000555555955134 0x0000000000401134 Y Y
> +7 16 0x0000555555955139 0x0000000000401139
> +8 21 0x0000555555955140 0x0000000000401140 Y
> +9 22 0x000055555595514f 0x000000000040114f Y Y
> +10 22 0x0000555555955154 0x0000000000401154
> +11 END 0x000055555595515a 0x000000000040115a Y
> @end smallexample
> @noindent
> +The @samp{UNREL-ADDRESS} column gives the unrelocated address of the
> +instruction as read from the debug information. The @samp{REL-ADDRESS} column
> +gives the corresponding address in the process memory (relocated address). If
process -> inferior, to be generic?
You could also say "in the current inferior's memory" to be more
precise, as the relocated address is given based on the current
inferior.
> +no process is started when executing this command, the relocated address is the
And therefore here, "If the current inferior is not running when
executing the command...".
> +same as the unrelocated address.
The two addresses can also be the same if the executable doesn't require
relocation. But your formulation doesn't imply that you are describing
all cases where addresses are equal, so perhaps we can leave that detail
out.
Simon
next prev parent reply other threads:[~2023-03-22 13:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 16:30 [PATCH] gdb: make "maintenance info line-table" show relocated addresses again Simon Marchi
2023-03-20 21:35 ` Andrew Burgess
2023-03-21 1:18 ` Simon Marchi
2023-03-21 9:23 ` Andrew Burgess
2023-03-22 1:35 ` Simon Marchi
2023-03-22 10:26 ` [PATCH 0/1] gdb: Update doc of the "maintenance info line-table" Lancelot SIX
2023-03-22 10:26 ` [PATCH 1/1] " Lancelot SIX
2023-03-22 13:59 ` Simon Marchi [this message]
2023-03-22 16:48 ` Lancelot SIX
2023-03-22 17:20 ` [PATCH v2] " Lancelot SIX
2023-03-22 14:58 ` [PATCH 1/1] " Eli Zaretskii
2023-03-22 13:46 ` [PATCH] gdb: make "maintenance info line-table" show relocated addresses again Tom de Vries
2023-03-22 13:47 ` Simon Marchi
2023-03-22 15:17 ` [PATCH] gdb/testsuite: adjust test cases to previous "maintenance info line-table" change Simon Marchi
2023-03-22 18:01 ` Tom de Vries
2023-03-22 19:14 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a38867b-e481-c4be-95db-0058afbaf2b3@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=lancelot.six@amd.com \
--cc=lsix@lancelotsix.com \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).