Re: [PATCH] Move 64-bit BFD files from ALL_TARGET_OBS to ALL_64_TARGET_OBS

[Luis Machado <luis.machado@arm.com>]

On 5/3/22 12:24, Pedro Alves wrote:
> On 2022-05-03 12:19, Luis Machado via Gdb-patches wrote:
> 
>> ---
>>   gdb/Makefile.in | 13 +++++++------
>>   1 file changed, 7 insertions(+), 6 deletions(-)
>>
>> diff --git a/gdb/Makefile.in b/gdb/Makefile.in
>> index 418094775a5..d80087749de 100644
>> --- a/gdb/Makefile.in
>> +++ b/gdb/Makefile.in
>> @@ -715,9 +715,12 @@ ALL_64_TARGET_OBS = \
>>   	arch/aarch64-mte-linux.o \
>>   	arch/amd64.o \
>>   	arch/riscv.o \
>> +	bpf-tdep.o \
>>   	ia64-linux-tdep.o \
>>   	ia64-tdep.o \
>>   	ia64-vms-tdep.o \
>> +	loongarch-linux-tdep.o \
>> +	loongarch-tdep.o \
>>   	mips-fbsd-tdep.o \
>>   	mips-linux-tdep.o \
>>   	mips-netbsd-tdep.o \
>> @@ -734,7 +737,10 @@ ALL_64_TARGET_OBS = \
>>   	sparc64-netbsd-tdep.o \
>>   	sparc64-obsd-tdep.o \
>>   	sparc64-sol2-tdep.o \
>> -	sparc64-tdep.o
>> +	sparc64-tdep.o \
>> +	tilegx-linux-tdep.o \
>> +	tilegx-tdep.o
>> +
>>   
> 
> Spurious empty line.

Fixed now.

> 
> In opcodes, tilegx is in TARGET32_LIBOPCODES_CFILES.  So why did we need to move that one?

*sigh*... I think that needs to be fixed as well.

opcodes/disassemble.c defines ARCH_tilegx if BFD64 is defined, which 
makes it a 64-bit BFD target. So a 32-bit build makes it not register a 
disassembler function (leading to GDB internal errors).

TILE-Gx is a 64-bit core according to 
https://en.wikipedia.org/wiki/TILE-Gx. So I suppose we need to move it 
from TARGET32_LIBOPCODES_CFILES to TARGET64_LIBOPCODES_CFILES.