From: Pedro Alves <pedro@palves.net>
To: Luis Machado <luis.machado@arm.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Move 64-bit BFD files from ALL_TARGET_OBS to ALL_64_TARGET_OBS
Date: Thu, 5 May 2022 11:29:12 +0100 [thread overview]
Message-ID: <d524040f-2011-d416-3781-61b26dd72eab@palves.net> (raw)
In-Reply-To: <4a965c5f-0ddf-f6e6-2578-8b45fb526611@arm.com>
On 2022-05-05 10:06, Luis Machado wrote:
> On 5/3/22 22:51, Luis Machado via Gdb-patches wrote:
>>>> In opcodes, tilegx is in TARGET32_LIBOPCODES_CFILES. So why did we need to move that one?
>>>
>>> *sigh*... I think that needs to be fixed as well.
>>>
>>> opcodes/disassemble.c defines ARCH_tilegx if BFD64 is defined, which makes it a 64-bit BFD target. So a 32-bit build makes it not register a disassembler function (leading to GDB internal errors).
>>>
>>> TILE-Gx is a 64-bit core according to https://en.wikipedia.org/wiki/TILE-Gx. So I suppose we need to move it from TARGET32_LIBOPCODES_CFILES to TARGET64_LIBOPCODES_CFILES.
>>
>> Patch to binutils sent here: https://sourceware.org/pipermail/binutils/2022-May/120651.html
>
> I've pushed the binutils patch. Are there any objections to the gdb-side patch?
Nope. Please go ahead and merge it.
next prev parent reply other threads:[~2022-05-05 10:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-03 11:19 Luis Machado
2022-05-03 11:24 ` Pedro Alves
2022-05-03 11:30 ` Luis Machado
2022-05-03 21:51 ` Luis Machado
2022-05-05 9:06 ` Luis Machado
2022-05-05 10:29 ` Pedro Alves [this message]
2022-05-30 10:25 ` Luis Machado
2022-05-26 7:22 ` Luis Machado
2022-05-26 13:57 ` Simon Marchi
2022-05-26 17:45 ` Luis Machado
2022-05-26 13:59 ` Tom Tromey
2022-05-26 17:50 ` Luis Machado
2022-05-03 15:21 ` Tom Tromey
2022-05-03 16:20 ` Luis Machado
2022-05-04 8:00 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d524040f-2011-d416-3781-61b26dd72eab@palves.net \
--to=pedro@palves.net \
--cc=gdb-patches@sourceware.org \
--cc=luis.machado@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).