From: Simon Marchi <simark@simark.ca>
To: Luis Machado <luis.machado@arm.com>,
Pedro Alves <pedro@palves.net>,
gdb-patches@sourceware.org
Subject: Re: [PATCH] Move 64-bit BFD files from ALL_TARGET_OBS to ALL_64_TARGET_OBS
Date: Thu, 26 May 2022 09:57:45 -0400 [thread overview]
Message-ID: <bb1d9dac-6324-9206-acdc-bb2dfbb017b4@simark.ca> (raw)
In-Reply-To: <de20c1c0-6945-0de4-e3e3-11522fc74458@arm.com>
On 2022-05-26 03:22, Luis Machado via Gdb-patches wrote:
> On 5/5/22 10:06, Luis Machado via Gdb-patches wrote:
>> On 5/3/22 22:51, Luis Machado via Gdb-patches wrote:
>>> On 5/3/22 12:30, Luis Machado via Gdb-patches wrote:
>>>> On 5/3/22 12:24, Pedro Alves wrote:
>>>>> On 2022-05-03 12:19, Luis Machado via Gdb-patches wrote:
>>>>>
>>>>>> ---
>>>>>> gdb/Makefile.in | 13 +++++++------
>>>>>> 1 file changed, 7 insertions(+), 6 deletions(-)
>>>>>>
>>>>>> diff --git a/gdb/Makefile.in b/gdb/Makefile.in
>>>>>> index 418094775a5..d80087749de 100644
>>>>>> --- a/gdb/Makefile.in
>>>>>> +++ b/gdb/Makefile.in
>>>>>> @@ -715,9 +715,12 @@ ALL_64_TARGET_OBS = \
>>>>>> arch/aarch64-mte-linux.o \
>>>>>> arch/amd64.o \
>>>>>> arch/riscv.o \
>>>>>> + bpf-tdep.o \
>>>>>> ia64-linux-tdep.o \
>>>>>> ia64-tdep.o \
>>>>>> ia64-vms-tdep.o \
>>>>>> + loongarch-linux-tdep.o \
>>>>>> + loongarch-tdep.o \
>>>>>> mips-fbsd-tdep.o \
>>>>>> mips-linux-tdep.o \
>>>>>> mips-netbsd-tdep.o \
>>>>>> @@ -734,7 +737,10 @@ ALL_64_TARGET_OBS = \
>>>>>> sparc64-netbsd-tdep.o \
>>>>>> sparc64-obsd-tdep.o \
>>>>>> sparc64-sol2-tdep.o \
>>>>>> - sparc64-tdep.o
>>>>>> + sparc64-tdep.o \
>>>>>> + tilegx-linux-tdep.o \
>>>>>> + tilegx-tdep.o
>>>>>> +
>>>>>
>>>>> Spurious empty line.
>>>>
>>>> Fixed now.
>>>>
>>>>>
>>>>> In opcodes, tilegx is in TARGET32_LIBOPCODES_CFILES. So why did we need to move that one?
>>>>
>>>> *sigh*... I think that needs to be fixed as well.
>>>>
>>>> opcodes/disassemble.c defines ARCH_tilegx if BFD64 is defined, which makes it a 64-bit BFD target. So a 32-bit build makes it not register a disassembler function (leading to GDB internal errors).
>>>>
>>>> TILE-Gx is a 64-bit core according to https://en.wikipedia.org/wiki/TILE-Gx. So I suppose we need to move it from TARGET32_LIBOPCODES_CFILES to TARGET64_LIBOPCODES_CFILES.
>>>
>>> Patch to binutils sent here: https://sourceware.org/pipermail/binutils/2022-May/120651.html
>>
>> I've pushed the binutils patch. Are there any objections to the gdb-side patch?
>
> Ping?
>
> 32-bit builds with --enable-targets=all are still failing due to the misplacement of these places.
>
> If we drop the tilegx change, would that be acceptable?
You might have not received, but Pedro said "Nope. Please go ahead and merge it." on
May 5th.
https://pi.simark.ca/gdb-patches/de20c1c0-6945-0de4-e3e3-11522fc74458@arm.com/T/#md5f08ad8f5b43fb3c3d0f731de2c807260197142
Simon
next prev parent reply other threads:[~2022-05-26 13:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-03 11:19 Luis Machado
2022-05-03 11:24 ` Pedro Alves
2022-05-03 11:30 ` Luis Machado
2022-05-03 21:51 ` Luis Machado
2022-05-05 9:06 ` Luis Machado
2022-05-05 10:29 ` Pedro Alves
2022-05-30 10:25 ` Luis Machado
2022-05-26 7:22 ` Luis Machado
2022-05-26 13:57 ` Simon Marchi [this message]
2022-05-26 17:45 ` Luis Machado
2022-05-26 13:59 ` Tom Tromey
2022-05-26 17:50 ` Luis Machado
2022-05-03 15:21 ` Tom Tromey
2022-05-03 16:20 ` Luis Machado
2022-05-04 8:00 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb1d9dac-6324-9206-acdc-bb2dfbb017b4@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=luis.machado@arm.com \
--cc=pedro@palves.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).