* [PATCH][gdb/testsuite] Fix gdb.reverse/i387-env-reverse.exp for -pie
@ 2022-06-22 13:05 Tom de Vries
2022-06-28 15:10 ` [committed][gdb/testsuite] " Tom de Vries
0 siblings, 1 reply; 2+ messages in thread
From: Tom de Vries @ 2022-06-22 13:05 UTC (permalink / raw)
To: gdb-patches
Hi,
When running test-case gdb.reverse/i387-env-reverse.exp for x86_64-linux with
target board unix/-m32/-fPIE/-pie, we run into:
...
(gdb) PASS: gdb.reverse/i387-env-reverse.exp: push st0
info register eax^M
eax 0x56550000 1448411136^M
(gdb) FAIL: gdb.reverse/i387-env-reverse.exp: verify eax == 0x8040000
...
The problem is that the tested instruction (fstsw) only sets $ax, not $eax.
Fix this by verifying $ax instead of $eax.
Tested on x86_64-linux with target boards unix/-m32 and unix/-m32/-fPIE/-pie.
Any comments?
Thanks,
- Tom
[gdb/testsuite] Fix gdb.reverse/i387-env-reverse.exp for -pie
---
gdb/testsuite/gdb.reverse/i387-env-reverse.exp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/testsuite/gdb.reverse/i387-env-reverse.exp b/gdb/testsuite/gdb.reverse/i387-env-reverse.exp
index a0a79c22ed0..53fee0986df 100644
--- a/gdb/testsuite/gdb.reverse/i387-env-reverse.exp
+++ b/gdb/testsuite/gdb.reverse/i387-env-reverse.exp
@@ -64,7 +64,7 @@ with_test_prefix "forward" {
gdb_test "n" "asm.*fstsw.*" "store status word in EAX"
gdb_test "n" "asm.*fld1.*" "push st0"
- gdb_test "info register eax" "eax *0x8040000.*\[ \t\]+.*" "verify eax == 0x8040000"
+ gdb_test "info register ax" "ax *0x0.*\[ \t\]+.*" "verify eax == 0x0"
gdb_test "info register fstat" "fstat *0.*\[ \t\]+.*" "verify fstat == 0"
gdb_test "info register ftag" "ftag *0xffff.*\[ \t\]+.*" "verify ftag == 0xffff"
^ permalink raw reply [flat|nested] 2+ messages in thread* [committed][gdb/testsuite] Fix gdb.reverse/i387-env-reverse.exp for -pie
2022-06-22 13:05 [PATCH][gdb/testsuite] Fix gdb.reverse/i387-env-reverse.exp for -pie Tom de Vries
@ 2022-06-28 15:10 ` Tom de Vries
0 siblings, 0 replies; 2+ messages in thread
From: Tom de Vries @ 2022-06-28 15:10 UTC (permalink / raw)
To: gdb-patches
On 6/22/22 15:05, Tom de Vries wrote:
> Hi,
>
> When running test-case gdb.reverse/i387-env-reverse.exp for x86_64-linux with
> target board unix/-m32/-fPIE/-pie, we run into:
> ...
> (gdb) PASS: gdb.reverse/i387-env-reverse.exp: push st0
> info register eax^M
> eax 0x56550000 1448411136^M
> (gdb) FAIL: gdb.reverse/i387-env-reverse.exp: verify eax == 0x8040000
> ...
>
> The problem is that the tested instruction (fstsw) only sets $ax, not $eax.
>
> Fix this by verifying $ax instead of $eax.
>
> Tested on x86_64-linux with target boards unix/-m32 and unix/-m32/-fPIE/-pie.
>
> Any comments?
Committed.
Thanks,
- Tom
> [gdb/testsuite] Fix gdb.reverse/i387-env-reverse.exp for -pie
>
> ---
> gdb/testsuite/gdb.reverse/i387-env-reverse.exp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gdb/testsuite/gdb.reverse/i387-env-reverse.exp b/gdb/testsuite/gdb.reverse/i387-env-reverse.exp
> index a0a79c22ed0..53fee0986df 100644
> --- a/gdb/testsuite/gdb.reverse/i387-env-reverse.exp
> +++ b/gdb/testsuite/gdb.reverse/i387-env-reverse.exp
> @@ -64,7 +64,7 @@ with_test_prefix "forward" {
> gdb_test "n" "asm.*fstsw.*" "store status word in EAX"
> gdb_test "n" "asm.*fld1.*" "push st0"
>
> - gdb_test "info register eax" "eax *0x8040000.*\[ \t\]+.*" "verify eax == 0x8040000"
> + gdb_test "info register ax" "ax *0x0.*\[ \t\]+.*" "verify eax == 0x0"
> gdb_test "info register fstat" "fstat *0.*\[ \t\]+.*" "verify fstat == 0"
> gdb_test "info register ftag" "ftag *0xffff.*\[ \t\]+.*" "verify ftag == 0xffff"
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-28 15:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-22 13:05 [PATCH][gdb/testsuite] Fix gdb.reverse/i387-env-reverse.exp for -pie Tom de Vries
2022-06-28 15:10 ` [committed][gdb/testsuite] " Tom de Vries
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).