From: Pedro Alves <pedro@palves.net>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 0/7] location -> location spec
Date: Fri, 17 Jun 2022 10:24:51 +0100 [thread overview]
Message-ID: <47ad1c90-417a-d123-a08d-bd8b6bb5719f@palves.net> (raw)
In-Reply-To: <871qvpyahm.fsf@tromey.com>
On 2022-06-15 20:47, Tom Tromey wrote:
>>>>>> Pedro Alves <pedro@palves.net> writes:
>
>> Currently, GDB internally uses the term "location" for both the
>> location specification the user had input, and for actual resolved
>> locations, like the breakpoint locations, or the result of decoding a
>> location spec to SaLs. This is expecially confusing in the
>> breakpoints module.
>
>> For the location spec, we currently have struct "event_location", and
>> even the "event" part is misnamed.
>
>> This series everything related to location specifications from
>> "location" to "location spec". event_location is renamed to
>> location_spec. And then cleans up location_spec and its subclasses.
>
> I agree with the renamings and changing to use methods.
> I didn't really read the patches carefully but I think you should check
> them in.
Thanks! I merged this now.
prev parent reply other threads:[~2022-06-17 9:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-27 18:02 Pedro Alves
2022-05-27 18:02 ` [PATCH 1/7] event_location -> location_spec Pedro Alves
2022-05-28 10:08 ` Philippe Waroquiers
2022-05-30 15:02 ` Pedro Alves
2022-05-27 18:02 ` [PATCH 2/7] Eliminate the two-level data structures behind location_specs Pedro Alves
2022-05-30 15:09 ` Pedro Alves
2022-05-27 18:02 ` [PATCH 3/7] Eliminate copy_location_spec Pedro Alves
2022-05-27 18:02 ` [PATCH 4/7] Convert location_spec_empty_p to a method Pedro Alves
2022-05-27 18:02 ` [PATCH 5/7] Convert location_spec_type " Pedro Alves
2022-05-27 18:02 ` [PATCH 6/7] Convert location_spec_to_string " Pedro Alves
2022-05-27 18:02 ` [PATCH 7/7] Convert set_location_spec_string " Pedro Alves
2022-05-30 15:20 ` Pedro Alves
2022-06-15 19:47 ` [PATCH 0/7] location -> location spec Tom Tromey
2022-06-17 9:24 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47ad1c90-417a-d123-a08d-bd8b6bb5719f@palves.net \
--to=pedro@palves.net \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).