Re: [PATCH 1/7] event_location -> location_spec

[Pedro Alves <pedro@palves.net>]

On 2022-05-28 11:08, Philippe Waroquiers wrote:
> On Fri, 2022-05-27 at 19:02 +0100, Pedro Alves wrote:
>> Currently, GDB internally uses the term "location" for both the
>> location specification the user input (linespec, explicit location, or
>> an address location), and for actual resolved locations, like the
>> breakpoint locations, or the result of decoding a location spec to
>> SaLs.  This is expecially confusing in the breakpoints module, as
>> struct breakpoint has these two fields:
> FWIW, I think that the introduction of location spec in the manual and in
> the code is a nice improvement/clarification.
> Thanks for Pedro and Eli hard work on this.

Thanks!

> 
> A small question:
> In GDB, when I do 
>   (gdb) apropos -v location
> possibly some occurrences of "location" might be changed by "locspec"
> or "location specification".
> (e.g.  in 'help breakpoint/break-range/disassemble/strace/...'
> and I have not seen that the patches are modifying this online help.

Yeah, I was waiting until the manual changes landed.  I will look into that as
a separate patch.

> Also, is the constant #define LOCATION_HELP_STRING
> not better called  LOCATION_SPEC_HELP_STRING ?

Indeed.  I've done that change locally.