From: Pedro Alves <pedro@palves.net>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/7] Eliminate the two-level data structures behind location_specs
Date: Mon, 30 May 2022 16:09:18 +0100 [thread overview]
Message-ID: <7a138daf-9ed8-574e-e381-b59b60b84046@palves.net> (raw)
In-Reply-To: <20220527180248.2990723-3-pedro@palves.net>
On 2022-05-27 19:02, Pedro Alves wrote:
> + std::unique_ptr<explicit_location_spec> els
> + (new explicit_location_spec ());
> + els->source_filename
> + = xstrdup (symtab_to_filename_for_display (sal2.symtab));
> + els->line_offset.offset = b->loc->line_number;
> + els->line_offset.sign = LINE_OFFSET_NONE;
> +
> + b->locspec.reset (els.release ());
I realized after sending the patch that even though els's type is
std::unique_ptr<explicit_location_spec>, and b->locspec is
a std::unique_ptr<location_spec>, we can do a move instead of
the reset/release above, like so:
b->locspec = std::move (els);
I've made that change locally, here and in a couple other spots that could
do it.
next prev parent reply other threads:[~2022-05-30 15:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-27 18:02 [PATCH 0/7] location -> location spec Pedro Alves
2022-05-27 18:02 ` [PATCH 1/7] event_location -> location_spec Pedro Alves
2022-05-28 10:08 ` Philippe Waroquiers
2022-05-30 15:02 ` Pedro Alves
2022-05-27 18:02 ` [PATCH 2/7] Eliminate the two-level data structures behind location_specs Pedro Alves
2022-05-30 15:09 ` Pedro Alves [this message]
2022-05-27 18:02 ` [PATCH 3/7] Eliminate copy_location_spec Pedro Alves
2022-05-27 18:02 ` [PATCH 4/7] Convert location_spec_empty_p to a method Pedro Alves
2022-05-27 18:02 ` [PATCH 5/7] Convert location_spec_type " Pedro Alves
2022-05-27 18:02 ` [PATCH 6/7] Convert location_spec_to_string " Pedro Alves
2022-05-27 18:02 ` [PATCH 7/7] Convert set_location_spec_string " Pedro Alves
2022-05-30 15:20 ` Pedro Alves
2022-06-15 19:47 ` [PATCH 0/7] location -> location spec Tom Tromey
2022-06-17 9:24 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a138daf-9ed8-574e-e381-b59b60b84046@palves.net \
--to=pedro@palves.net \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).