Re: [PATCH] gdb: fix command lookup in execute_command ()

[Simon Marchi <simark@simark.ca>]

On 12/13/22 13:48, Jan Vraný wrote:
> On Tue, 2022-12-13 at 08:05 -0700, Tom Tromey wrote:
>>>>>>> "Jan" == Jan Vrany via Gdb-patches <gdb-patches@sourceware.org> writes:
>>
>> Jan> The below patch should fix this case - with it on my system
>> Jan> gdb.base/define.exp passes.
>>
>> Jan> Alternatively I may just revert the commit until better solution
>> Jan> is found.
>>
>> This patch looks ok to me, but could you say whether you ran all the
>> tests or just define.exp?  Given the history I think a full regression
>> test is warranted.
> 
> I did use try-build which succeeded (build #28) but it seems to me it
> runs only very limited number of tests. 
> 
> I did run all of gdb.base and did not spot any new regression compared
> to master with my (previous, broken) patch reverted. I did not run more
> than gdb.base mainly because just gdb.base takes about an hour on my machine.
> Also I get weird intermittent failures when running testsuite. 
> 
> Jan

Here are the unexpected failures I saw:

UNRESOLVED: gdb.base/bp-cmds-execution-x-script.exp: run to end
UNRESOLVED: gdb.base/bp-cmds-run-with-ex.exp: execute bp commands
UNRESOLVED: gdb.base/bp-cmds-sourced-script.exp: source the script
UNRESOLVED: gdb.base/bp-cmds-sourced-script.exp: continue until exit
UNRESOLVED: gdb.base/commands.exp: deprecated_command_test: source file containing xxx_yyy command and its alias
UNRESOLVED: gdb.base/commands.exp: deprecated_command_test: deprecated alias with prefix give a warning
UNRESOLVED: gdb.base/commands.exp: deprecated_command_alias_help_test: define real_command: input 1: define real_command
UNRESOLVED: gdb.base/commands.exp: deprecated_command_alias_help_test: alias alias_command = real_command
UNRESOLVED: gdb.base/commands.exp: deprecated_command_alias_help_test: alias alias_with_args_command = real_command 123
UNRESOLVED: gdb.base/commands.exp: deprecated_command_alias_help_test: help real_command, before
UNRESOLVED: gdb.base/commands.exp: deprecated_command_alias_help_test: maintenance deprecate alias_command
UNRESOLVED: gdb.base/commands.exp: deprecated_command_alias_help_test: maintenance deprecate alias_with_args_command
UNRESOLVED: gdb.base/commands.exp: deprecated_command_alias_help_test: help real_command, after
UNRESOLVED: gdb.base/commands.exp: bp_deleted_in_command_test: delete all breakpoints in delete_breakpoints
UNRESOLVED: gdb.base/commands.exp: bp_deleted_in_command_test: break factorial
UNRESOLVED: gdb.base/commands.exp: bp_deleted_in_command_test: begin commands
UNRESOLVED: gdb.base/commands.exp: bp_deleted_in_command_test: add silent command
UNRESOLVED: gdb.base/commands.exp: bp_deleted_in_command_test: add clear command
UNRESOLVED: gdb.base/commands.exp: bp_deleted_in_command_test: add printf command
UNRESOLVED: gdb.base/commands.exp: bp_deleted_in_command_test: add cont command
UNRESOLVED: gdb.base/commands.exp: bp_deleted_in_command_test: end commands
UNRESOLVED: gdb.base/commands.exp: temporary_breakpoint_commands: delete all breakpoints in delete_breakpoints
UNRESOLVED: gdb.base/commands.exp: temporary_breakpoint_commands: breakpoint
UNRESOLVED: gdb.base/commands.exp: temporary_breakpoint_commands: begin commands in bp_deleted_in_command_test
UNRESOLVED: gdb.base/commands.exp: temporary_breakpoint_commands: add silent tbreak command
UNRESOLVED: gdb.base/commands.exp: temporary_breakpoint_commands: add printf tbreak command
UNRESOLVED: gdb.base/commands.exp: temporary_breakpoint_commands: add cont tbreak command
UNRESOLVED: gdb.base/commands.exp: temporary_breakpoint_commands: end tbreak commands
UNRESOLVED: gdb.base/commands.exp: stray_arg0_test: #1
UNRESOLVED: gdb.base/commands.exp: stray_arg0_test: #2
UNRESOLVED: gdb.base/commands.exp: stray_arg0_test: #3
UNRESOLVED: gdb.base/commands.exp: stray_arg0_test: #4
UNRESOLVED: gdb.base/commands.exp: source_file_with_indented_comment: source file
UNRESOLVED: gdb.base/commands.exp: recursive_source_test: source file
UNRESOLVED: gdb.base/commands.exp: if_commands_test: set $tem
UNRESOLVED: gdb.base/commands.exp: if_commands_test: if $tem == 2 - if_commands_test 1
UNRESOLVED: gdb.base/commands.exp: if_commands_test: break -q main - if_commands_test 1
UNRESOLVED: gdb.base/commands.exp: if_commands_test: else - if_commands_test 1
UNRESOLVED: gdb.base/commands.exp: if_commands_test: break factorial - if_commands_test 1
UNRESOLVED: gdb.base/commands.exp: if_commands_test: commands - if_commands_test 1
UNRESOLVED: gdb.base/commands.exp: if_commands_test: silent - if_commands_test 1
UNRESOLVED: gdb.base/commands.exp: if_commands_test: set $tem = 3 - if_commands_test 1
UNRESOLVED: gdb.base/commands.exp: if_commands_test: continue - if_commands_test 1
UNRESOLVED: gdb.base/commands.exp: if_commands_test: first end - if_commands_test 1
UNRESOLVED: gdb.base/commands.exp: if_commands_test: second end - if_commands_test 1
UNRESOLVED: gdb.base/commands.exp: if_commands_test: if $tem == 1 - if_commands_test 2
UNRESOLVED: gdb.base/commands.exp: if_commands_test: break -q main - if_commands_test 2
UNRESOLVED: gdb.base/commands.exp: if_commands_test: else - if_commands_test 2
UNRESOLVED: gdb.base/commands.exp: if_commands_test: break factorial - if_commands_test 2
UNRESOLVED: gdb.base/commands.exp: if_commands_test: commands - if_commands_test 2
UNRESOLVED: gdb.base/commands.exp: if_commands_test: silent - if_commands_test 2
UNRESOLVED: gdb.base/commands.exp: if_commands_test: set $tem = 3 - if_commands_test 2
UNRESOLVED: gdb.base/commands.exp: if_commands_test: continue - if_commands_test 2
UNRESOLVED: gdb.base/commands.exp: if_commands_test: first end - if_commands_test 2
UNRESOLVED: gdb.base/commands.exp: if_commands_test: second end - if_commands_test 2
UNRESOLVED: gdb.base/commands.exp: error_clears_commands_left: hook-stop 1
UNRESOLVED: gdb.base/commands.exp: error_clears_commands_left: hook-stop 1a
UNRESOLVED: gdb.base/commands.exp: error_clears_commands_left: hook-stop 1b
UNRESOLVED: gdb.base/commands.exp: error_clears_commands_left: delete all breakpoints in delete_breakpoints
UNRESOLVED: gdb.base/dprintf-execution-x-script.exp: load and run script with -x
UNRESOLVED: gdb.base/dprintf-execution-x-script.exp: load and run script using source command
UNRESOLVED: gdb.base/dprintf-execution-x-script.exp: run again
UNRESOLVED: gdb.base/save-bp.exp: source bps
UNRESOLVED: gdb.base/save-bp.exp: info break (pattern 1) (timeout)
UNRESOLVED: gdb.base/trace-commands.exp: source -v (pattern 4) (timeout)
UNRESOLVED: gdb.base/trace-commands.exp: set trace-commands
UNRESOLVED: gdb.base/trace-commands.exp: show trace-commands says on
UNRESOLVED: gdb.base/trace-commands.exp: simple trace-commands test
UNRESOLVED: gdb.base/trace-commands.exp: nested trace-commands test (pattern 1) (timeout)
UNRESOLVED: gdb.base/trace-commands.exp: define user command (pattern 1) (timeout)
UNRESOLVED: gdb.base/trace-commands.exp: nested trace-commands test with source (pattern 1) (timeout)
UNRESOLVED: gdb.base/trace-commands.exp: depth resets on error part 1 (pattern 1) (timeout)
UNRESOLVED: gdb.base/trace-commands.exp: depth resets on error part 2
UNRESOLVED: gdb.trace/save-trace.exp: relative: read back saved tracepoints
UNRESOLVED: gdb.trace/save-trace.exp: relative: verify recovered tracepoints
DUPLICATE: gdb.trace/save-trace.exp: relative: verify recovered tracepoints
UNRESOLVED: gdb.trace/save-trace.exp: relative: verify default-collect
UNRESOLVED: gdb.trace/save-trace.exp: absolute: save tracepoint definitions
UNRESOLVED: gdb.trace/save-trace.exp: absolute: clear default-collect
UNRESOLVED: gdb.trace/save-trace.exp: absolute: delete tracepoints
UNRESOLVED: gdb.trace/save-trace.exp: absolute: read back saved tracepoints
UNRESOLVED: gdb.trace/save-trace.exp: absolute: verify recovered tracepoints
DUPLICATE: gdb.trace/save-trace.exp: absolute: verify recovered tracepoints
UNRESOLVED: gdb.trace/save-trace.exp: absolute: verify default-collect
UNRESOLVED: gdb.trace/save-trace.exp: verify help save tracepoints

Simon