From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>,
Jan Vrany via Gdb-patches <gdb-patches@sourceware.org>
Cc: Jan Vrany <jan.vrany@labware.com>, luis.machado@arm.com
Subject: Re: [PATCH] gdb: fix command lookup in execute_command () commands"
Date: Wed, 14 Dec 2022 11:01:02 -0500 [thread overview]
Message-ID: <603b56b4-5983-832d-89ad-7e1f7669065c@simark.ca> (raw)
In-Reply-To: <87lenadlhr.fsf@tromey.com>
On 12/14/22 10:59, Tom Tromey wrote:
> Simon> Here are the unexpected failures I saw:
>
> [...]
>
> Jan> Hmm. I do not see these failures.
>
> I applied the patch and ran the full test suite. I'm on x86-64 Fedora 34.
>
> I see two new FAILs but they are in thread tests and so I assume they
> are just the usual kind of racy test thing.
>
> I didn't see any of the failures that Simon reports.
>
> So, from my perspective your proposed patch seems fine. I don't think
> we need to back out the previous patch.
>
> Simon, could you maybe double-check your results somehow? Or pick one
> of the failures and try to see why it's happening?
>
> thanks,
> Tom
Do you have ASan enabled in that build?
Simon
next prev parent reply other threads:[~2022-12-14 16:01 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-08 14:20 [PATCH] gdb: fix possible use-after-free when executing commands Jan Vrany
2022-12-09 17:55 ` Tom Tromey
2022-12-12 15:05 ` Luis Machado
2022-12-12 15:08 ` Jan Vraný
2022-12-12 15:09 ` Luis Machado
2022-12-13 11:22 ` [PATCH] gdb: fix command lookup in execute_command () Jan Vrany
2022-12-13 15:05 ` Tom Tromey
2022-12-13 16:43 ` Simon Marchi
2022-12-13 18:48 ` Jan Vraný
2022-12-13 19:29 ` Simon Marchi
2022-12-14 11:07 ` [PATCH] gdb: fix command lookup in execute_command () commands" Jan Vrany
2022-12-14 15:35 ` Simon Marchi
2022-12-14 15:41 ` Jan Vraný
2022-12-14 15:59 ` Tom Tromey
2022-12-14 16:01 ` Simon Marchi [this message]
2022-12-14 18:05 ` Tom Tromey
2022-12-14 18:30 ` Simon Marchi
2022-12-14 22:01 ` Simon Marchi
2022-12-16 14:07 ` [PATCH] gdb: fix command lookup in execute_command () Jan Vraný
2022-12-16 16:47 ` Simon Marchi
2022-12-19 11:48 ` Jan Vraný
2022-12-19 14:46 ` Tom Tromey
2022-12-19 15:51 ` Jan Vraný
2022-12-20 19:10 ` Tom Tromey
2022-12-14 19:52 ` [PATCH] gdb: fix possible use-after-free when executing commands Simon Marchi
2022-12-14 20:39 ` Jan Vraný
2022-12-14 20:42 ` Simon Marchi
2022-12-15 12:57 ` Jan Vrany
2022-12-15 13:53 ` Simon Marchi
2022-12-15 14:51 ` Jan Vrany
2022-12-15 16:00 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=603b56b4-5983-832d-89ad-7e1f7669065c@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=jan.vrany@labware.com \
--cc=luis.machado@arm.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).