Re: [PATCH] Fix gdb.fortran "failed to extract expected results" errors

[Simon Marchi <simon.marchi@polymtl.ca>]

On 2022-02-25 11:40, Tom Tromey wrote:
>>>>>> "Keith" == Keith Seitz via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
> Keith> When running the gdb.fortran tests array-slices.exp and lbound-ubound.exp,
> Keith> the test suite throws several ERRORs on native-gdbserver/-m{32,64},
> Keith> and native-extended-gdbsever/-m{32,64}:
> 
> Keith> [on native-extended-gdbserver/-m64]
> Keith> Running /home/keiths/work/gdb/branches/testsuite-errors/linux/gdb/testsuite/../../../src/gdb/testsuite/gdb.fortran/array-slices.exp ...
> Keith> ERROR: failed to extract expected results
> Keith> ERROR: failed to extract expected results
> Keith> Running /home/keiths/work/gdb/branches/testsuite-errors/linux/gdb/testsuite/../../../src/gdb/testsuite/gdb.fortran/lbound-ubound.exp ...
> Keith> ERROR: failed to extract expected results for lbound
> 
> Keith> This occurs because the tests require inferior I/O which we do not have
> Keith> access to while using these targets.
> 
> Keith> This patch skips these tests when running on non-native targets.
> 
> Looks good to me.
> 
> Tom

An alternative would be to change those tests to not rely on inferior IO.

They could perhaps save the expected outcome to a string, which GDB would
read, rather than printing it to stdout.

But, that takes some time, and most importantly, someone who knows
Fortran :).  So I also think your patch is ok.

Simon