From: Keith Seitz <keiths@redhat.com>
To: Keith Seitz via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix gdb.fortran "failed to extract expected results" errors
Date: Mon, 28 Feb 2022 07:35:56 -0800 [thread overview]
Message-ID: <ed527a93-bd7f-fdd9-7be8-281bae4c3297@redhat.com> (raw)
In-Reply-To: <4f0def89-1a03-3d2c-15a0-572f0bb7566a@polymtl.ca>
On 2/25/22 08:48, Simon Marchi via Gdb-patches wrote:
>
>
> On 2022-02-25 11:40, Tom Tromey wrote:
>>>>>>> "Keith" == Keith Seitz via Gdb-patches <gdb-patches@sourceware.org> writes:
>>
>>
>> Keith> This patch skips these tests when running on non-native targets.
>>
>> Looks good to me.
>
> An alternative would be to change those tests to not rely on inferior IO.
>
> They could perhaps save the expected outcome to a string, which GDB would
> read, rather than printing it to stdout.
>
> But, that takes some time, and most importantly, someone who knows
> Fortran :). So I also think your patch is ok.
Oh, you got me! :-)
That's a good point, though. I will see if I can update this test, but in the
meantime, I've pushed this change. All these errors are interfering with our
Fedora CI efforts.
Thank you, Tom and Simon!
Keith
next prev parent reply other threads:[~2022-02-28 15:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 17:41 Keith Seitz
2022-02-25 16:40 ` Tom Tromey
2022-02-25 16:48 ` Simon Marchi
2022-02-28 15:35 ` Keith Seitz [this message]
2022-03-03 20:02 ` Pedro Alves
2022-03-07 14:27 ` [PATCH] Make gdb.fortran/{array-slices,lbound-ubound} work against gdbserver Pedro Alves
2022-03-09 17:21 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed527a93-bd7f-fdd9-7be8-281bae4c3297@redhat.com \
--to=keiths@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).