From: Tom Tromey <tom@tromey.com>
To: Pedro Alves <pedro@palves.net>
Cc: Keith Seitz <keiths@redhat.com>,
Keith Seitz via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Make gdb.fortran/{array-slices,lbound-ubound} work against gdbserver
Date: Wed, 09 Mar 2022 10:21:55 -0700 [thread overview]
Message-ID: <87h787oxcc.fsf@tromey.com> (raw)
In-Reply-To: <a057ae60-f8f1-ded8-aca1-79e58a6e4a1a@palves.net> (Pedro Alves's message of "Mon, 7 Mar 2022 14:27:31 +0000")
>>>>> "Pedro" == Pedro Alves <pedro@palves.net> writes:
Pedro> Keith mentioned he might be away this week, so I went ahead and played with this. We
Pedro> can't use gdb_test_stdio here, because that maps to gdb_test, and we want gdb_test_multiple
Pedro> instead. So we use inferior_spawn_id with gdb_test_multiple instead.
Thanks.
Pedro> It took me some head scratching and staring at logs to figure out why the patch
Pedro> wasn't working -- I was hitting a buglet in gdb.fortran/array-slices.f90, argh.
Pedro> With that out of the way, both testcases now pass cleanly with gdbserver too.
Pedro> Here's the proposed patch. Any comments?
It looks fine to me.
Tom
prev parent reply other threads:[~2022-03-09 17:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 17:41 [PATCH] Fix gdb.fortran "failed to extract expected results" errors Keith Seitz
2022-02-25 16:40 ` Tom Tromey
2022-02-25 16:48 ` Simon Marchi
2022-02-28 15:35 ` Keith Seitz
2022-03-03 20:02 ` Pedro Alves
2022-03-07 14:27 ` [PATCH] Make gdb.fortran/{array-slices,lbound-ubound} work against gdbserver Pedro Alves
2022-03-09 17:21 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h787oxcc.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
--cc=pedro@palves.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).