From: John Baldwin <jhb@FreeBSD.org>
To: Simon Marchi <simon.marchi@polymtl.ca>, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/3] gdb: break up core_target initialization
Date: Wed, 30 Nov 2022 09:29:43 -0800 [thread overview]
Message-ID: <50ef5c6b-7062-3eac-c739-fa8b442d4288@FreeBSD.org> (raw)
In-Reply-To: <2ce82756-688c-3f32-d2f4-2fa450290c5d@polymtl.ca>
On 11/29/22 1:53 PM, Simon Marchi wrote:
> What about:
>
>
> core_target::core_target ()
> {
> /* Find a first arch based on the BFD. It will possibly be overriden by a
> more precise gdbarch in core_target::initialize */
> m_core_gdbarch = gdbarch_from_bfd (core_bfd);
> }
>
> void
> core_target::initialize ()
> {
> /* If the initial arch (obtained from the BFD) is able to read a target
> description from the core, it could yield a more specific gdbarch. */
> const struct target_desc *tdesc = read_description ();
>
> Simon
This looks good to me, thanks!
--
John Baldwin
next prev parent reply other threads:[~2022-11-30 17:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-29 2:50 [PATCH 1/3] gdb: add inferior_target_stack_changed observer, use it to clear auxv cache Simon Marchi
2022-11-29 2:50 ` [PATCH 2/3] gdb: break up core_target initialization Simon Marchi
2022-11-29 19:27 ` John Baldwin
2022-11-29 21:53 ` Simon Marchi
2022-11-30 17:29 ` John Baldwin [this message]
2022-11-30 16:05 ` Tom Tromey
2022-12-02 19:38 ` Simon Marchi
2022-11-29 2:50 ` [PATCH 3/3] gdb: remove target_ops parameter from gdbarch_core_read_description Simon Marchi
2022-11-29 19:16 ` John Baldwin
2022-11-29 21:45 ` Simon Marchi
2022-12-02 20:51 ` [PATCH v1.1 " Simon Marchi
2022-11-30 15:44 ` [PATCH 1/3] gdb: add inferior_target_stack_changed observer, use it to clear auxv cache Tom Tromey
2022-12-02 19:36 ` Simon Marchi
2022-12-02 20:59 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50ef5c6b-7062-3eac-c739-fa8b442d4288@FreeBSD.org \
--to=jhb@freebsd.org \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).