From: Tom Tromey <tom@tromey.com>
To: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Cc: Simon Marchi <simon.marchi@polymtl.ca>
Subject: Re: [PATCH 1/3] gdb: add inferior_target_stack_changed observer, use it to clear auxv cache
Date: Wed, 30 Nov 2022 08:44:08 -0700 [thread overview]
Message-ID: <874jugo3av.fsf@tromey.com> (raw)
In-Reply-To: <20221129025048.44490-1-simon.marchi@polymtl.ca> (Simon Marchi via Gdb-patches's message of "Mon, 28 Nov 2022 21:50:46 -0500")
>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
Simon> Add an inferior_target_stack_changed observable, and attach
Simon> invalidate_auxv_cache_inf to it. Notify this observable in the
Simon> push_target and unpush_target methods of inferior.
This looks good to me, thanks.
It seems like overall it would be better to have the auxv cache just be
some member of 'inferior'. Then these indirections and observers
wouldn't be needed -- the inferior could just manage it directly.
Tom
next prev parent reply other threads:[~2022-11-30 15:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-29 2:50 Simon Marchi
2022-11-29 2:50 ` [PATCH 2/3] gdb: break up core_target initialization Simon Marchi
2022-11-29 19:27 ` John Baldwin
2022-11-29 21:53 ` Simon Marchi
2022-11-30 17:29 ` John Baldwin
2022-11-30 16:05 ` Tom Tromey
2022-12-02 19:38 ` Simon Marchi
2022-11-29 2:50 ` [PATCH 3/3] gdb: remove target_ops parameter from gdbarch_core_read_description Simon Marchi
2022-11-29 19:16 ` John Baldwin
2022-11-29 21:45 ` Simon Marchi
2022-12-02 20:51 ` [PATCH v1.1 " Simon Marchi
2022-11-30 15:44 ` Tom Tromey [this message]
2022-12-02 19:36 ` [PATCH 1/3] gdb: add inferior_target_stack_changed observer, use it to clear auxv cache Simon Marchi
2022-12-02 20:59 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jugo3av.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).