From: Ivan Tetyushkin <ivan.tetyushkin@syntacore.com>
To: Andrew Burgess <aburgess@redhat.com>,
Tom de Vries <tdevries@suse.de>,
gdb-patches@sourceware.org,
Andrew Burgess <andrew.burgess@embecosm.com>
Subject: Re: [PATCH 2/7] [gdb/testsuite] fix test gdb.base/print-file-var.exp for remote execution
Date: Mon, 7 Nov 2022 16:49:18 +0300 [thread overview]
Message-ID: <5111034b-a2ad-ef85-9498-dd2603122a38@syntacore.com> (raw)
In-Reply-To: <87cz9yc2kz.fsf@redhat.com>
Hi
Yes, this patch fixes this test. However, it will not fix gdb.base/infcall-exec.exp from the patch 5/7 of this thread.
As I can understand now, this test uses absolute paths for checking, but relative paths are used during compilation. We can change regexp itself and check only filename, but this could lead to false positive result.
Also, I thought these tests are created to work with absolute paths to ignore solib-search-path.
--
Ivan
next prev parent reply other threads:[~2022-11-07 13:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-25 16:29 [PATCH 0/7] introduce get_runtime_path Ivan Tetyushkin
2022-10-25 16:29 ` [PATCH 1/7] [gdb/testsuite] Adding function to find runtime path to support remote execution for testsuite Ivan Tetyushkin
2022-10-25 16:29 ` [PATCH 2/7] [gdb/testsuite] fix test gdb.base/print-file-var.exp for remote execution Ivan Tetyushkin
2022-11-06 10:54 ` Tom de Vries
2022-11-07 13:32 ` Andrew Burgess
2022-11-07 13:49 ` Ivan Tetyushkin [this message]
2022-11-07 16:44 ` Tom de Vries
2022-11-15 14:39 ` Tom de Vries
2022-11-07 16:18 ` Tom de Vries
2022-11-07 13:55 ` Simon Marchi
2022-11-07 16:15 ` Tom de Vries
2022-10-25 16:29 ` [PATCH 3/7] [gdb/testsuite] fix test gdb.base/jit-reader-exec.exp " Ivan Tetyushkin
2022-10-25 16:29 ` [PATCH 4/7] [gdb/testsuite] fix test gdb.base/solib-vanish.exp " Ivan Tetyushkin
2022-10-25 16:29 ` [PATCH 5/7] [gdb/testsuite] fix test gdb.base/infcall-exec.exp " Ivan Tetyushkin
2022-10-25 16:29 ` [PATCH 6/7] [gdb/testsuite] fix test gdb.base/info-shared.exp " Ivan Tetyushkin
2022-10-25 16:29 ` [PATCH 7/7] [gdb/testsuite] fix test gdb.base/jit-elf-so.exp " Ivan Tetyushkin
2022-10-29 9:20 ` [PATCH 0/7] introduce get_runtime_path Andrew Burgess
2022-11-01 9:19 ` Ivan Tetyushkin
2022-11-05 14:39 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5111034b-a2ad-ef85-9498-dd2603122a38@syntacore.com \
--to=ivan.tetyushkin@syntacore.com \
--cc=aburgess@redhat.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).