* [PATCH] Silence libtool during link
@ 2022-11-07 18:13 Tom Tromey
2022-11-07 18:16 ` Simon Marchi
0 siblings, 1 reply; 2+ messages in thread
From: Tom Tromey @ 2022-11-07 18:13 UTC (permalink / raw)
To: gdb-patches; +Cc: Tom Tromey
The switch to linking with libtool now shows a very long link line
even when V=0. This patch arranges to silence libtool in this
situation.
---
gdb/Makefile.in | 2 +-
gdb/silent-rules.mk | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/gdb/Makefile.in b/gdb/Makefile.in
index 522fc20bccd..0f5df2ccb7b 100644
--- a/gdb/Makefile.in
+++ b/gdb/Makefile.in
@@ -148,7 +148,7 @@ LIBTOOL = @LIBTOOL@
# Set this up with gcc if you have gnu ld and the loader will print out
# line numbers for undefined references.
#CC_LD = g++ -static
-CC_LD = $(LIBTOOL) --mode=link $(CXX) $(CXX_DIALECT)
+CC_LD = $(LIBTOOL) $(SILENT_FLAG) --mode=link $(CXX) $(CXX_DIALECT)
# Where is our "include" directory? Typically $(srcdir)/../include.
# This is essentially the header file directory for the library
diff --git a/gdb/silent-rules.mk b/gdb/silent-rules.mk
index c2c43481296..36791f6683f 100644
--- a/gdb/silent-rules.mk
+++ b/gdb/silent-rules.mk
@@ -18,4 +18,6 @@ ECHO_LEX = @echo " LEX $@";
ECHO_AR = @echo " AR $@";
ECHO_RANLIB = @echo " RANLIB $@";
SILENCE = @
+# Silence libtool.
+SILENT_FLAG = --silent
endif
--
2.34.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Silence libtool during link
2022-11-07 18:13 [PATCH] Silence libtool during link Tom Tromey
@ 2022-11-07 18:16 ` Simon Marchi
0 siblings, 0 replies; 2+ messages in thread
From: Simon Marchi @ 2022-11-07 18:16 UTC (permalink / raw)
To: Tom Tromey, gdb-patches
On 11/7/22 13:13, Tom Tromey via Gdb-patches wrote:
> The switch to linking with libtool now shows a very long link line
> even when V=0. This patch arranges to silence libtool in this
> situation.
> ---
> gdb/Makefile.in | 2 +-
> gdb/silent-rules.mk | 2 ++
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/gdb/Makefile.in b/gdb/Makefile.in
> index 522fc20bccd..0f5df2ccb7b 100644
> --- a/gdb/Makefile.in
> +++ b/gdb/Makefile.in
> @@ -148,7 +148,7 @@ LIBTOOL = @LIBTOOL@
> # Set this up with gcc if you have gnu ld and the loader will print out
> # line numbers for undefined references.
> #CC_LD = g++ -static
> -CC_LD = $(LIBTOOL) --mode=link $(CXX) $(CXX_DIALECT)
> +CC_LD = $(LIBTOOL) $(SILENT_FLAG) --mode=link $(CXX) $(CXX_DIALECT)
>
> # Where is our "include" directory? Typically $(srcdir)/../include.
> # This is essentially the header file directory for the library
> diff --git a/gdb/silent-rules.mk b/gdb/silent-rules.mk
> index c2c43481296..36791f6683f 100644
> --- a/gdb/silent-rules.mk
> +++ b/gdb/silent-rules.mk
> @@ -18,4 +18,6 @@ ECHO_LEX = @echo " LEX $@";
> ECHO_AR = @echo " AR $@";
> ECHO_RANLIB = @echo " RANLIB $@";
> SILENCE = @
> +# Silence libtool.
> +SILENT_FLAG = --silent
> endif
Oops, I had not noticed that during review. LGTM:
Approved-By: Simon Marchi <simon.marchi@efficios.com>
Simon
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-07 18:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-07 18:13 [PATCH] Silence libtool during link Tom Tromey
2022-11-07 18:16 ` Simon Marchi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).