From: Simon Marchi <simon.marchi@polymtl.ca>
To: "Maciej W. Rozycki" <macro@orcam.me.uk>
Cc: Dragan Mladjenovic <Dragan.Mladjenovic@syrmia.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
Chao-ying Fu <cfu@wavecomp.com>
Subject: Re: [PATCH^2] gdb: mips: Add MIPSR6 support
Date: Fri, 1 Sep 2023 11:14:45 -0400 [thread overview]
Message-ID: <5be0e6eb-c786-4676-b620-2f1886c18c31@polymtl.ca> (raw)
In-Reply-To: <alpine.DEB.2.21.2308312209000.43104@angie.orcam.me.uk>
On 8/31/23 17:36, Maciej W. Rozycki wrote:
> Hi Simon,
>
>> I can do a superficial review (formatting / coding style / general
>> feeling), but can't speak about the behavior. Ideally Maciej would look
>> at it, but if he's not available, I would be fine approving the patch,
>> since it's isolated to the MIPS support. The code looks nice and
>> well-organized.
>
> I can try, but I have been rather overloaded these days, and the change
> is sufficiently large it probably requires a number of working days to
> review in detail just for the initial iteration, as there's a lot to
> cross-check here with documentation (there's always a second pair of
> educated eyes required for this kind of a change).
I agree, it's not something that can be properly reviewed with just a
few minutes (even hours) to spare.
> Mind that it's something I'd have to do entirely in my free time, and
> also that I have no MIPSr6 hardware available, so that would include time
> required to set up QEMU (assuming that it works without glitches) to do
> any R6 verification (and this change still has to be verified not to break
> existing MIPS targets). That's why I offer support primarily to other
> enthusiasts running legacy MIPS hardware.
That's completely understandable. That said, if somebody else that is
trustworthy has a long term interest in the MIPS support in GDB
(especially if it's a commercial interest), we could think about
onboarding them as co-maintainers for the port.
Simon
next prev parent reply other threads:[~2023-09-01 15:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 18:02 Dragan Mladjenovic
2023-08-01 12:12 ` Dragan Mladjenovic
2023-08-31 9:50 ` Dragan Mladjenovic
2023-08-31 17:56 ` Simon Marchi
2023-08-31 21:36 ` Maciej W. Rozycki
2023-09-01 15:14 ` Simon Marchi [this message]
2023-09-04 21:34 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5be0e6eb-c786-4676-b620-2f1886c18c31@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=Dragan.Mladjenovic@syrmia.com \
--cc=cfu@wavecomp.com \
--cc=gdb-patches@sourceware.org \
--cc=macro@orcam.me.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).