* [PATCH] Fix btrace regression
@ 2023-03-01 1:45 Tom Tromey
2023-03-01 8:39 ` Tom de Vries
0 siblings, 1 reply; 2+ messages in thread
From: Tom Tromey @ 2023-03-01 1:45 UTC (permalink / raw)
To: gdb-patches; +Cc: Tom Tromey
Tom de Vries pointed out that my earlier patch:
commit 873a185be258ad2552b9579005852815b4da5baf
Date: Fri Dec 16 07:56:57 2022 -0700
Don't use struct buffer in handle_qxfer_btrace
regressed gdb.btrace/reconnect.exp. I didn't notice this because I
did not have libipt installed.
This patch fixes the bug.
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30169
---
gdbserver/linux-low.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdbserver/linux-low.cc b/gdbserver/linux-low.cc
index dec1944d45f..0ca3bb1cd6a 100644
--- a/gdbserver/linux-low.cc
+++ b/gdbserver/linux-low.cc
@@ -6781,7 +6781,7 @@ linux_low_encode_raw (std::string *buffer, const gdb_byte *data,
elem[0] = tohex ((*data >> 4) & 0xf);
elem[1] = tohex (*data++ & 0xf);
- buffer->append (elem);
+ buffer->append (elem, 2);
}
*buffer += "</raw>\n";
--
2.39.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix btrace regression
2023-03-01 1:45 [PATCH] Fix btrace regression Tom Tromey
@ 2023-03-01 8:39 ` Tom de Vries
0 siblings, 0 replies; 2+ messages in thread
From: Tom de Vries @ 2023-03-01 8:39 UTC (permalink / raw)
To: Tom Tromey, gdb-patches
On 3/1/23 02:45, Tom Tromey wrote:
> Tom de Vries pointed out that my earlier patch:
>
> commit 873a185be258ad2552b9579005852815b4da5baf
> Date: Fri Dec 16 07:56:57 2022 -0700
>
> Don't use struct buffer in handle_qxfer_btrace
>
> regressed gdb.btrace/reconnect.exp. I didn't notice this because I
> did not have libipt installed.
>
> This patch fixes the bug.
>
> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30169
Hi,
Fix LGTM.
I've also tested it, and it fixes the FAIL for me.
Thanks,
- Tom
> ---
> gdbserver/linux-low.cc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gdbserver/linux-low.cc b/gdbserver/linux-low.cc
> index dec1944d45f..0ca3bb1cd6a 100644
> --- a/gdbserver/linux-low.cc
> +++ b/gdbserver/linux-low.cc
> @@ -6781,7 +6781,7 @@ linux_low_encode_raw (std::string *buffer, const gdb_byte *data,
> elem[0] = tohex ((*data >> 4) & 0xf);
> elem[1] = tohex (*data++ & 0xf);
>
> - buffer->append (elem);
> + buffer->append (elem, 2);
> }
>
> *buffer += "</raw>\n";
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-01 8:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-01 1:45 [PATCH] Fix btrace regression Tom Tromey
2023-03-01 8:39 ` Tom de Vries
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).