From: Simon Marchi <simark@simark.ca>
To: "Sébastien Michelland"
<sebastien.michelland@lcis.grenoble-inp.fr>,
gdb-patches@sourceware.org
Subject: Re: [PING] [PATCH v2] gdb: specify sh pointer register types
Date: Fri, 26 Apr 2024 10:00:28 -0400 [thread overview]
Message-ID: <671f4e94-f752-4ed5-8c41-513e976cafbb@simark.ca> (raw)
In-Reply-To: <2ecb6676-fab7-4f7b-96d0-f867990f2f60@lcis.grenoble-inp.fr>
On 2024-04-26 04:13, Sébastien Michelland wrote:
> Hi everyone, kindly pinging for process for this patch.
>
> Simon approved the approach on a previous version but this one still needs validation, and ultimately a push if accepted.
>
> I understand there is little maintenance going on for the sh target. Is there additional testing I should do to help with this patch?
Hi Sébastien,
I went ahead and pushed the patch. You don't seem to have on the
copyright assignment on file for GDB, but I considered that the patch
was small enough for it to be ok (hopefully, we can start accepting
patches with Signed-Off-By and no copyright assignment soon).
In terms of testing, this architecture is relatively uncommon, so I'll
just take your word for it that you did your best :). If you want to go
further to improve the SH port, you can always try to run the testsuite
and see what fails. It might not be trivial depending on your setup, be
we can always help.
Simon
prev parent reply other threads:[~2024-04-26 14:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-01 9:55 Sébastien Michelland
2024-04-09 23:18 ` Luis Machado
2024-04-10 7:03 ` Sébastien Michelland
2024-04-10 8:01 ` Luis Machado
2024-04-26 8:13 ` [PING] " Sébastien Michelland
2024-04-26 14:00 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=671f4e94-f752-4ed5-8c41-513e976cafbb@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=sebastien.michelland@lcis.grenoble-inp.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).