From: Pedro Alves <pedro@palves.net>
To: Andrew Burgess <aburgess@redhat.com>,
Bruno Larsen <blarsen@redhat.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/testsuite: modernize gdb.base/maint.exp
Date: Fri, 24 Jun 2022 16:13:53 +0100 [thread overview]
Message-ID: <6abb48e4-019c-d2c6-5565-3a471249dbfc@palves.net> (raw)
In-Reply-To: <87k096b3k5.fsf@redhat.com>
On 2022-06-24 14:20, Andrew Burgess via Gdb-patches wrote:
> You could use just:
>
> gdb_assert { $seen_command }
>
> here. Or maybe:
>
> gdb_assert { $seen_command } $gdb_test_name
>
> Or possibly even:
>
> gdb_assert { $seen_command }
> pass $gdb_test_name
>
> I think option #2 would be my pick, but whatever you prefer is fine I think.
>
I think option #2:
gdb_assert { $seen_command } $gdb_test_name
is the right one, as it keeps pass/fail balanced if this test ever fails
without reaching the prompt regexp match.
next prev parent reply other threads:[~2022-06-24 15:13 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-09 18:04 Bruno Larsen
2022-05-23 14:14 ` [PING] " Bruno Larsen
2022-05-30 11:14 ` [PINGv2] " Bruno Larsen
2022-06-06 12:43 ` [PINGv3] " Bruno Larsen
2022-06-13 20:03 ` [PINGv4] " Bruno Larsen
2022-06-20 13:29 ` [PINGv5] " Bruno Larsen
2022-06-21 15:52 ` Andrew Burgess
2022-06-21 19:45 ` Bruno Larsen
2022-06-21 19:54 ` [PATCHv2] " Bruno Larsen
2022-06-24 13:20 ` [PATCH] " Andrew Burgess
2022-06-24 15:13 ` Pedro Alves [this message]
2022-06-24 15:16 ` Pedro Alves
2022-06-24 15:23 ` Pedro Alves
2022-06-24 15:22 ` Pedro Alves
2022-06-24 17:51 ` Keith Seitz
2022-06-24 17:54 ` Bruno Larsen
2022-06-24 18:41 ` Pedro Alves
2022-06-27 10:13 ` Andrew Burgess
2022-06-28 18:36 ` [PATCHv3] " Bruno Larsen
2022-06-29 10:33 ` Andrew Burgess
2022-06-29 14:00 ` Bruno Larsen
2022-06-29 14:53 ` [PATCHv4] " Bruno Larsen
2022-07-13 11:22 ` [PING][PATCHv4] " Bruno Larsen
2022-07-15 16:49 ` Tom Tromey
2022-07-15 17:20 ` Bruno Larsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6abb48e4-019c-d2c6-5565-3a471249dbfc@palves.net \
--to=pedro@palves.net \
--cc=aburgess@redhat.com \
--cc=blarsen@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).