Re: [PATCH] gdb/testsuite: modernize gdb.base/maint.exp

[Pedro Alves <pedro@palves.net>]

On 2022-06-21 20:45, Bruno Larsen via Gdb-patches wrote:
> +# When there is a problem, there may be loads of output, which can
> +# overwhelm the expect buffer. Splitting it seems to fix those
> +# issues.
> +
> +set seen_command 0
> +gdb_test_multiple "maint check-psymtabs" "" {
> +    -re "^maint check-psymtabs\r\n" {
> +	set seen_command 1
> +	exp_continue
> +    }
>  
> -# guo: on linux this command output is huge.  for some reason splitting up
> -# the regexp checks works.
> -#
> -send_gdb "maint check-psymtabs\n"
> -gdb_expect  {
> -    -re "^maint check-psymtabs" {
> -	gdb_expect {
> -	    -re "$gdb_prompt $" {
> -		pass "maint check-psymtabs"
> -	    }
> -	    timeout { fail "(timeout) maint check-psymtabs" }
> +    -re "^$gdb_prompt $" {
> +	if { $seen_command == 1 } {
> +	    pass "maint check-psymtabs"
> +	} else {
> +	    fail $gdb_test_name
>  	}
>      }
> -    -re ".*$gdb_prompt $"     { fail "maint check-psymtabs" }
> -    timeout         { fail "(timeout) maint check-psymtabs" }
> +
> +    -re "^\[^\r\n\]+\r\n" {
> +	exp_continue
> +    }

I think that instead of adding this line match, you can pass -lbl to gdb_test_multiple.