* [PATCH v2] gdb/testsuite: Add support for LoongArch in gdb.base/float.exp
@ 2023-03-09 12:54 Hui Li
2023-03-11 3:00 ` Simon Marchi
2023-03-16 15:04 ` Tiezhu Yang
0 siblings, 2 replies; 3+ messages in thread
From: Hui Li @ 2023-03-09 12:54 UTC (permalink / raw)
To: gdb-patches
The test results on LoongArch as follows:
Without this patch:
```
$ make check-gdb TESTS="gdb.base/float.exp"
=== gdb Summary ===
# of expected passes 2
# of unexpected failures 1
```
With this patch:
```
$ make check-gdb TESTS="gdb.base/float.exp"
=== gdb Summary ===
# of expected passes 3
```
Signed-off-by: Hui Li <lihui@loongson.cn>
---
gdb/testsuite/gdb.base/float.exp | 2 ++
1 file changed, 2 insertions(+)
diff --git a/gdb/testsuite/gdb.base/float.exp b/gdb/testsuite/gdb.base/float.exp
index 7f230cb6f61..5e9be538b73 100644
--- a/gdb/testsuite/gdb.base/float.exp
+++ b/gdb/testsuite/gdb.base/float.exp
@@ -126,6 +126,8 @@ if {[is_aarch64_target]} {
pass "info float (without FPU)"
}
}
+} elseif {[istarget "loongarch*-*-*"]} {
+ gdb_test "info float" "f.*fcc0.*fcsr.*" "info float"
} else {
gdb_test "info float" "No floating.point info available for this processor." "info float (unknown target)"
}
--
2.38.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] gdb/testsuite: Add support for LoongArch in gdb.base/float.exp
2023-03-09 12:54 [PATCH v2] gdb/testsuite: Add support for LoongArch in gdb.base/float.exp Hui Li
@ 2023-03-11 3:00 ` Simon Marchi
2023-03-16 15:04 ` Tiezhu Yang
1 sibling, 0 replies; 3+ messages in thread
From: Simon Marchi @ 2023-03-11 3:00 UTC (permalink / raw)
To: Hui Li, gdb-patches
On 3/9/23 07:54, Hui Li wrote:
> The test results on LoongArch as follows:
>
> Without this patch:
>
> ```
> $ make check-gdb TESTS="gdb.base/float.exp"
> === gdb Summary ===
>
> # of expected passes 2
> # of unexpected failures 1
>
> ```
> With this patch:
>
> ```
> $ make check-gdb TESTS="gdb.base/float.exp"
> === gdb Summary ===
>
> # of expected passes 3
>
> ```
>
> Signed-off-by: Hui Li <lihui@loongson.cn>
> ---
> gdb/testsuite/gdb.base/float.exp | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/gdb/testsuite/gdb.base/float.exp b/gdb/testsuite/gdb.base/float.exp
> index 7f230cb6f61..5e9be538b73 100644
> --- a/gdb/testsuite/gdb.base/float.exp
> +++ b/gdb/testsuite/gdb.base/float.exp
> @@ -126,6 +126,8 @@ if {[is_aarch64_target]} {
> pass "info float (without FPU)"
> }
> }
> +} elseif {[istarget "loongarch*-*-*"]} {
> + gdb_test "info float" "f.*fcc0.*fcsr.*" "info float"
> } else {
> gdb_test "info float" "No floating.point info available for this processor." "info float (unknown target)"
> }
This is ok:
Approved-By: Simon Marchi <simon.marchi@efficios.com>
Simon
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] gdb/testsuite: Add support for LoongArch in gdb.base/float.exp
2023-03-09 12:54 [PATCH v2] gdb/testsuite: Add support for LoongArch in gdb.base/float.exp Hui Li
2023-03-11 3:00 ` Simon Marchi
@ 2023-03-16 15:04 ` Tiezhu Yang
1 sibling, 0 replies; 3+ messages in thread
From: Tiezhu Yang @ 2023-03-16 15:04 UTC (permalink / raw)
To: Hui Li, gdb-patches
On 3/9/23 20:54, Hui Li wrote:
> The test results on LoongArch as follows:
>
> Without this patch:
>
> ```
> $ make check-gdb TESTS="gdb.base/float.exp"
> === gdb Summary ===
>
> # of expected passes 2
> # of unexpected failures 1
>
> ```
> With this patch:
>
> ```
> $ make check-gdb TESTS="gdb.base/float.exp"
> === gdb Summary ===
>
> # of expected passes 3
>
> ```
>
> Signed-off-by: Hui Li <lihui@loongson.cn>
> ---
> gdb/testsuite/gdb.base/float.exp | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/gdb/testsuite/gdb.base/float.exp b/gdb/testsuite/gdb.base/float.exp
> index 7f230cb6f61..5e9be538b73 100644
> --- a/gdb/testsuite/gdb.base/float.exp
> +++ b/gdb/testsuite/gdb.base/float.exp
> @@ -126,6 +126,8 @@ if {[is_aarch64_target]} {
> pass "info float (without FPU)"
> }
> }
> +} elseif {[istarget "loongarch*-*-*"]} {
> + gdb_test "info float" "f.*fcc0.*fcsr.*" "info float"
> } else {
> gdb_test "info float" "No floating.point info available for this processor." "info float (unknown target)"
> }
Looks good to me, tested on LoongArch, pushed.
Thanks,
Tiezhu
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-16 15:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-09 12:54 [PATCH v2] gdb/testsuite: Add support for LoongArch in gdb.base/float.exp Hui Li
2023-03-11 3:00 ` Simon Marchi
2023-03-16 15:04 ` Tiezhu Yang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).