* [PATCH] gdb/Makefile.in: remove ACLOCAL_AMFLAGS
@ 2024-03-11 19:32 Simon Marchi
2024-03-11 20:19 ` Tom Tromey
0 siblings, 1 reply; 3+ messages in thread
From: Simon Marchi @ 2024-03-11 19:32 UTC (permalink / raw)
To: gdb-patches; +Cc: Simon Marchi
aclocal picks up the relevant include paths from AC_CONFIG_MACRO_DIRS in
configure.ac, so there's no need to pass `-I ../config` here.
Passing `-I ../config` is actually annoying, because it makes the output
different between when the update is triggered by the maintainer mode
and when aclocal or autoreconf is ran with no special flags. The
difference in the output is due to the order of include paths being
different.
Change-Id: I2c963876516570842f20b4a6a470867e7a941006
---
gdb/Makefile.in | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/gdb/Makefile.in b/gdb/Makefile.in
index 0e0f19c40c9f..e83fbc5d146a 100644
--- a/gdb/Makefile.in
+++ b/gdb/Makefile.in
@@ -2317,7 +2317,6 @@ config.status: $(srcdir)/configure configure.nat configure.tgt configure.host ..
$(SHELL) config.status --recheck
ACLOCAL = aclocal
-ACLOCAL_AMFLAGS = -I ../config
# Keep these in sync with the includes in acinclude.m4.
aclocal_m4_deps = \
@@ -2345,7 +2344,7 @@ aclocal_m4_deps = \
../config/ax_pthread.m4
$(srcdir)/aclocal.m4: @MAINTAINER_MODE_TRUE@ $(aclocal_m4_deps)
- cd $(srcdir) && $(ACLOCAL) $(ACLOCAL_AMFLAGS)
+ cd $(srcdir) && $(ACLOCAL)
AUTOCONF = autoconf
configure_deps = $(srcdir)/configure.ac $(srcdir)/aclocal.m4
base-commit: 1320cb92da10d194a5bb0c34ce552dffa52faeb5
--
2.44.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gdb/Makefile.in: remove ACLOCAL_AMFLAGS
2024-03-11 19:32 [PATCH] gdb/Makefile.in: remove ACLOCAL_AMFLAGS Simon Marchi
@ 2024-03-11 20:19 ` Tom Tromey
2024-03-11 21:02 ` Simon Marchi
0 siblings, 1 reply; 3+ messages in thread
From: Tom Tromey @ 2024-03-11 20:19 UTC (permalink / raw)
To: Simon Marchi; +Cc: gdb-patches
>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:
Simon> aclocal picks up the relevant include paths from AC_CONFIG_MACRO_DIRS in
Simon> configure.ac, so there's no need to pass `-I ../config` here.
Simon> Passing `-I ../config` is actually annoying, because it makes the output
Simon> different between when the update is triggered by the maintainer mode
Simon> and when aclocal or autoreconf is ran with no special flags. The
Simon> difference in the output is due to the order of include paths being
Simon> different.
Thanks.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gdb/Makefile.in: remove ACLOCAL_AMFLAGS
2024-03-11 20:19 ` Tom Tromey
@ 2024-03-11 21:02 ` Simon Marchi
0 siblings, 0 replies; 3+ messages in thread
From: Simon Marchi @ 2024-03-11 21:02 UTC (permalink / raw)
To: Tom Tromey; +Cc: gdb-patches
On 3/11/24 16:19, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:
>
> Simon> aclocal picks up the relevant include paths from AC_CONFIG_MACRO_DIRS in
> Simon> configure.ac, so there's no need to pass `-I ../config` here.
>
> Simon> Passing `-I ../config` is actually annoying, because it makes the output
> Simon> different between when the update is triggered by the maintainer mode
> Simon> and when aclocal or autoreconf is ran with no special flags. The
> Simon> difference in the output is due to the order of include paths being
> Simon> different.
>
> Thanks.
> Approved-By: Tom Tromey <tom@tromey.com>
>
> Tom
Thanks, pushed.
Simon
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-03-11 21:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-11 19:32 [PATCH] gdb/Makefile.in: remove ACLOCAL_AMFLAGS Simon Marchi
2024-03-11 20:19 ` Tom Tromey
2024-03-11 21:02 ` Simon Marchi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).