[PATCH][gdb/testsuite] Fix gdb.opt/inline-small-func.exp with clang

[PATCH][gdb/testsuite] Fix gdb.opt/inline-small-func.exp with clang

[Tom de Vries]

Hi,

When running test-case gdb.opt/inline-small-func.exp with clang 12.0.1, I run
into:
...
gdb compile failed, /usr/bin/ld: inline-small-func0.o: in function `main':
inline-small-func.c:21: undefined reference to `callee'
clang-12.0: error: linker command failed with exit code 1 \
  (use -v to see invocation)
UNTESTED: gdb.opt/inline-small-func.exp: failed to prepare
...

Fix this by using __attribute__((always_inline)).

Tested on x86_64-linux.

Any comments?

Thanks,
- Tom

[gdb/testsuite] Fix gdb.opt/inline-small-func.exp with clang

---
 gdb/testsuite/gdb.opt/inline-small-func.h | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/gdb/testsuite/gdb.opt/inline-small-func.h b/gdb/testsuite/gdb.opt/inline-small-func.h
index 66323952cf4..44b6e86fc15 100644
--- a/gdb/testsuite/gdb.opt/inline-small-func.h
+++ b/gdb/testsuite/gdb.opt/inline-small-func.h
@@ -13,9 +13,15 @@
    You should have received a copy of the GNU General Public License
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
+#ifdef __GNUC__
+#define ATTR __attribute__((always_inline))
+#else
+#define ATTR
+#endif
+
 int counter = 42;
 
-inline void
+inline ATTR void
 callee () {
   counter = 0;	/* callee: body.  */
 }

Re: [PATCH][gdb/testsuite] Fix gdb.opt/inline-small-func.exp with clang

[Luis Machado]

On 7/26/22 12:30, Tom de Vries via Gdb-patches wrote:
> Hi,
> 
> When running test-case gdb.opt/inline-small-func.exp with clang 12.0.1, I run
> into:
> ...
> gdb compile failed, /usr/bin/ld: inline-small-func0.o: in function `main':
> inline-small-func.c:21: undefined reference to `callee'
> clang-12.0: error: linker command failed with exit code 1 \
>    (use -v to see invocation)
> UNTESTED: gdb.opt/inline-small-func.exp: failed to prepare
> ...
> 
> Fix this by using __attribute__((always_inline)).
> 
> Tested on x86_64-linux.
> 
> Any comments?
> 
> Thanks,
> - Tom
> 
> [gdb/testsuite] Fix gdb.opt/inline-small-func.exp with clang
> 
> ---
>   gdb/testsuite/gdb.opt/inline-small-func.h | 8 +++++++-
>   1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/gdb/testsuite/gdb.opt/inline-small-func.h b/gdb/testsuite/gdb.opt/inline-small-func.h
> index 66323952cf4..44b6e86fc15 100644
> --- a/gdb/testsuite/gdb.opt/inline-small-func.h
> +++ b/gdb/testsuite/gdb.opt/inline-small-func.h
> @@ -13,9 +13,15 @@
>      You should have received a copy of the GNU General Public License
>      along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
>   
> +#ifdef __GNUC__
> +#define ATTR __attribute__((always_inline))
> +#else
> +#define ATTR
> +#endif
> +
>   int counter = 42;
>   
> -inline void
> +inline ATTR void
>   callee () {
>     counter = 0;	/* callee: body.  */
>   }

The above looks good to me.