From: Simon Marchi <simon.marchi@polymtl.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: add "set debug solib" and use it
Date: Mon, 21 Nov 2022 15:02:08 -0500 [thread overview]
Message-ID: <7dc71740-a5ca-0c47-134f-a02d58026ce4@polymtl.ca> (raw)
In-Reply-To: <83zgck13q4.fsf@gnu.org>
On 11/21/22 14:56, Eli Zaretskii wrote:
>> Cc: Simon Marchi <simon.marchi@efficios.com>
>> Date: Mon, 21 Nov 2022 14:36:36 -0500
>> From: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
>>
>> From: Simon Marchi <simon.marchi@efficios.com>
>>
>> I'd like to add some debug output to solib-svr4. Add a "set debug
>> solib" knob, which can then be used in all solib-* files. Then, add
>> the debug output I needed, related to the svr4 shared library event
>> breakpoint probes.
>
> Not sure I understand: we already have "set debug aix-solib" and "set debug
> solib-frv". So this is going to be "set debug svr4-solib"? Or do you mean
> to make a single "set debug solib" command for all platforms?
The new command was intended to be used by all solib implementations,
but I missed the existing commands you pointed out. I think it would be
fine to have a single knob for all solib implementations. In general,
only one solib implementation will be used at any given time.
If you agree, I would remove the two existing commands in favor of the
new "set debug solib", and then add my solib-svr4 changes.
>
> Thanks.
>
>> gdb/NEWS | 4 ++++
>> gdb/doc/gdb.texinfo | 6 ++++++
>> gdb/solib-svr4.c | 23 ++++++++++++++++++++++-
>> gdb/solib.c | 8 ++------
>> gdb/solib.h | 12 ++++++++++++
>> 5 files changed, 46 insertions(+), 7 deletions(-)
>
> The documentation parts are okay, but the text sounds as if this command is
> available on all platforms.
That is the intention.
Simon
next prev parent reply other threads:[~2022-11-21 20:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 19:36 Simon Marchi
2022-11-21 19:56 ` Eli Zaretskii
2022-11-21 20:02 ` Simon Marchi [this message]
2022-11-21 20:19 ` Eli Zaretskii
2022-11-21 20:24 ` Simon Marchi
2022-11-21 20:24 ` Simon Marchi
2022-11-28 15:27 ` Tom Tromey
2022-11-28 16:57 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7dc71740-a5ca-0c47-134f-a02d58026ce4@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).