Re: [PATCH] gdb: add "set debug solib" and use it

[Simon Marchi <simon.marchi@polymtl.ca>]

On 11/21/22 15:24, Simon Marchi wrote:
> 
> 
> On 11/21/22 15:19, Eli Zaretskii wrote:
>>> Date: Mon, 21 Nov 2022 15:02:08 -0500
>>> Cc: gdb-patches@sourceware.org
>>> From: Simon Marchi <simon.marchi@polymtl.ca>
>>>
>>>> Not sure I understand: we already have "set debug aix-solib" and "set debug
>>>> solib-frv".  So this is going to be "set debug svr4-solib"?  Or do you mean
>>>> to make a single "set debug solib" command for all platforms?
>>>
>>> The new command was intended to be used by all solib implementations,
>>> but I missed the existing commands you pointed out.  I think it would be
>>> fine to have a single knob for all solib implementations.  In general,
>>> only one solib implementation will be used at any given time.
>>>
>>> If you agree, I would remove the two existing commands in favor of the
>>> new "set debug solib", and then add my solib-svr4 changes.
>>
>> I have no use for those two commands, but I guess users of AIX and FRV do?
>> Can we just delete the commands from under their feet?
> 
> I tend to view "set debug" commands, as internal commands (maybe they
> should be maintenance commands, really), I wouldn't feel bad to just
> remove them.  Or we could keep them as deprecated aliases of the new
> command.  Or, I could just add "set debug solib-svr", if that makes

solib-svr4, sorry.

Simon