[PATCH] PowerPC, fix test gdb.base/watchpoint-stops-at-right-insn.exp

[PATCH] PowerPC, fix test gdb.base/watchpoint-stops-at-right-insn.exp

[Carl Love]

GDB maintainers:

The following patch disables the gdb.base/watchpoint-stops-at-right-
insn.exp test on Power 9.  The Power 9 processor does not support
hardware breakpoints due to a HW bug.  The test should be skipped on
Power 9.

The following patch updates the test for hardware watchpoint support to
use the correct test skip_hw_watchpoint_tests on PowerPC to determine
if the PowerPC processor supports hardware watchpoints.

The patch has been tested on X86-64, Power 9 and Power 10 with no
regressions.

Please let me know if the patch is acceptable.  Thanks.

                    Carl Love


----------------------------------------
PowerPC, fix test gdb.base/watchpoint-stops-at-right-insn.exp

Test gdb.base/watchpoint-stops-at-right-insn.exp generates 4 test errors
on Power 9.  The test uses the test [target_info exists gdb,
no_hardware_watchpoints] to determine if the processor supports hardware
watchpoints.  The check only examines the processor type to determine if
it supports hardware watchpoints.  Note, the test works fine on Power 10.

The PowerPC processors support hardware watchpoints with the
exception of Power 9. The hardware watchpoint support was disabled on
Power 9 due to a hardware bug.  The test skip_hw_watchpoint_tests must
be used to correctly determine if the PowerPC processor supports
hardware watchpoints.

This patch replaces the [target_info exists gdb,no_hardware_watchpoints]
with the skip_hw_watchpoint_tests_p check.  With the patch, the test is
disabled on Power 9 but runs on all other PowerPC processors.

The patch has been tested on Power 9, Power 10 and X86-64 with no
regression failures.
---
 gdb/testsuite/gdb.base/watchpoint-stops-at-right-insn.exp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/testsuite/gdb.base/watchpoint-stops-at-right-insn.exp b/gdb/testsuite/gdb.base/watchpoint-stops-at-right-insn.exp
index f9adb1f4f91..6c445d4cbd8 100644
--- a/gdb/testsuite/gdb.base/watchpoint-stops-at-right-insn.exp
+++ b/gdb/testsuite/gdb.base/watchpoint-stops-at-right-insn.exp
@@ -71,7 +71,7 @@
 standard_testfile
 
 # No use testing this if we can't use hardware watchpoints.
-if {[target_info exists gdb,no_hardware_watchpoints]} {
+if {[skip_hw_watchpoint_tests]} {
     return -1
 }
 
-- 
2.37.2

Re: [PATCH] PowerPC, fix test gdb.base/watchpoint-stops-at-right-insn.exp

[Ulrich Weigand]

Carl Love <cel@us.ibm.com> wrote:

>PowerPC, fix test gdb.base/watchpoint-stops-at-right-insn.exp

This is OK.

Thanks,
Ulrich