From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Set _WIN32_WINNT in common.m4 configure check
Date: Mon, 09 Jan 2023 18:41:51 +0200 [thread overview]
Message-ID: <83358jpsmo.fsf@gnu.org> (raw)
In-Reply-To: <20230109144716.1988567-1-tromey@adacore.com> (message from Tom Tromey via Gdb-patches on Mon, 9 Jan 2023 07:47:16 -0700)
> Cc: Tom Tromey <tromey@adacore.com>
> Date: Mon, 9 Jan 2023 07:47:16 -0700
> From: Tom Tromey via Gdb-patches <gdb-patches@sourceware.org>
>
> GCC recently added support for the Windows thread model, enabling
> libstdc++ to support Windows natively. However, this supporrt
> requires a version of Windows later than the minimum version that is
> supported by GDB.
>
> PR build/29966 points out that the GDB configure test for std::thread
> does not work in this situation, because _WIN32_WINNT is not defined
> in test program, and so <thread> seems to be fine.
>
> This patch is an attempt to fix the problem, by using the same setting
> for _WIN32_WINNT at configure time as is used at build time.
>
> I don't have access to one of the older systems so I don't think I can
> truly test this. I did do a mingw cross build, though. I'm going to
> ask the bug reporter to test it.
The patch LGTM, but of course actually testing on an old system would
be the best.
Thanks.
next prev parent reply other threads:[~2023-01-09 16:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 14:47 Tom Tromey
2023-01-09 15:27 ` Tom Tromey
2023-01-09 16:41 ` Eli Zaretskii [this message]
2023-01-11 17:30 ` Tom Tromey
2023-01-12 5:22 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83358jpsmo.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).