From: Tom Tromey <tromey@adacore.com>
To: Tom Tromey via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom Tromey <tromey@adacore.com>, Joel Brobecker <brobecker@adacore.com>
Subject: Re: [PATCH] Set _WIN32_WINNT in common.m4 configure check
Date: Wed, 11 Jan 2023 10:30:31 -0700 [thread overview]
Message-ID: <87ilhd6kso.fsf@tromey.com> (raw)
In-Reply-To: <20230109144716.1988567-1-tromey@adacore.com> (Tom Tromey via Gdb-patches's message of "Mon, 9 Jan 2023 07:47:16 -0700")
>>>>> "Tom" == Tom Tromey via Gdb-patches <gdb-patches@sourceware.org> writes:
Tom> GCC recently added support for the Windows thread model, enabling
Tom> libstdc++ to support Windows natively. However, this supporrt
Tom> requires a version of Windows later than the minimum version that is
Tom> supported by GDB.
Tom> PR build/29966 points out that the GDB configure test for std::thread
Tom> does not work in this situation, because _WIN32_WINNT is not defined
Tom> in test program, and so <thread> seems to be fine.
Tom> This patch is an attempt to fix the problem, by using the same setting
Tom> for _WIN32_WINNT at configure time as is used at build time.
Tom> I don't have access to one of the older systems so I don't think I can
Tom> truly test this. I did do a mingw cross build, though. I'm going to
Tom> ask the bug reporter to test it.
There turns out to also be some small problem in libstdc++ so this patch
can't fully be confirmed. However it also seems like an improvement, so
I am going to check it in.
Joel, I tend to think we should consider this for GDB 13. Without it,
GDB 13 won't build with a newer GCC on some older Windows systems.
Tom
next prev parent reply other threads:[~2023-01-11 17:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 14:47 Tom Tromey
2023-01-09 15:27 ` Tom Tromey
2023-01-09 16:41 ` Eli Zaretskii
2023-01-11 17:30 ` Tom Tromey [this message]
2023-01-12 5:22 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ilhd6kso.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).