Re: [PATCH 2/2] gdb: add support for disassembler styling using libopcodes

[Eli Zaretskii <eliz@gnu.org>]

> Date: Fri, 17 Jun 2022 11:36:02 +0100
> From: Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>
> Cc: Andrew Burgess <aburgess@redhat.com>
> 
>  gdb/NEWS            |  28 +++++++
>  gdb/cli/cli-style.c | 107 +++++++++++++++++++++++---
>  gdb/cli/cli-style.h |  28 +++++--
>  gdb/disasm.c        | 184 ++++++++++++++++++++++++++++++++++++++++++--
>  gdb/disasm.h        |  16 ++++
>  gdb/doc/gdb.texinfo | 100 +++++++++++++++++++++++-
>  6 files changed, 437 insertions(+), 26 deletions(-)

Thanks, the documentation parts are approved, with these minor nits:

> @@ -26485,13 +26486,30 @@
>  general is enabled (with @code{set style enabled on}), and if a source
>  highlighting library is available to @value{GDBN}.
>  
> -To highlight disassembler output, @value{GDBN} must be compiled with
> -Python support, and the Python Pygments package must be available.  If
> -these requirements are not met then @value{GDBN} will not highlight
> -disassembler output, even when this option is @samp{on}.
> +The two source highlighting libraries that @value{GDBN} could use are;
> +@value{GDBN}'s builtin disassembler, or the Python Pygments package.

The original text explicitly talked about styling disassembler output,
whereas the new text omits that qualification, and sounds as if it is
talking about styling in general.  Although this is in a section about
disassembly, I'd prefer to keep the original qualification.

> +If neither of these options are available then @value{GDBN} will
> +produce unstyled output, even when this setting is @samp{on}.

Same here.

> +@item disassembler immediate
> +Control the styling of numeric operands in the disassembler output.
> +These are managed with the @code{set style disassembler immediate}
> +family of commands.  This style is not used for instruction operands
> +that represent addresses, in that case the @samp{disassembler address}
> +style is used. This style is only used when @value{GDBN} is styling
                ^^
Two spaces between sentences.

> +@anchor{maint_libopcodes_styling}
> +@kindex maint set libopcodes-styling enabled
> +@kindex maint show libopcodes-styling enabled
> +@item maint set libopcodes-styling enabled @r{[}on|off@r{]}
> +@itemx maint show libopcodes-styling enabled
> +Control whether @value{GDBN} should use its builtin disassembler
> +(libopcodes) to style disassembler output (@pxref{Output Styling}).
    ^^^^^^^^^^
"libopcodes" should have the @file markup.