public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Andrew Burgess <aburgess@redhat.com>
To: gdb-patches@sourceware.org
Cc: Andrew Burgess <aburgess@redhat.com>
Subject: [PATCH 0/2] Fix some undefined haviour bugs in Python disassembler API
Date: Wed, 20 Jul 2022 14:14:35 +0100	[thread overview]
Message-ID: <cover.1658322626.git.aburgess@redhat.com> (raw)
In-Reply-To: <60eaedb1-8caf-1a52-0875-e3c5f5c8d8d4@simark.ca>

Simon,

Thanks for finding this problem.  The first patch here fixes the
problem you found.  While testing this first patch I found another
issue, which is what the second patch fixes.

I'll probably push these in a few days unless I get some objections.

Let me know if you have any thoughts,

Thanks,
Andrew

---

Andrew Burgess (2):
  gdb: fix use of uninitialised gdb_printing_disassembler::m_in_comment
  gdb/python: fix invalid use disassemble_info::stream

 gdb/disasm.h                           |  2 +-
 gdb/python/py-disasm.c                 |  2 +-
 gdb/testsuite/gdb.python/py-disasm.c   |  8 +++++++-
 gdb/testsuite/gdb.python/py-disasm.exp | 22 ++++++++++++++--------
 gdb/testsuite/gdb.python/py-disasm.py  |  3 ---
 5 files changed, 23 insertions(+), 14 deletions(-)

-- 
2.25.4


  reply	other threads:[~2022-07-20 13:15 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-17 10:36 [PATCH 0/2] Use libopcodes disassembler styling with GDB Andrew Burgess
2022-06-17 10:36 ` [PATCH 1/2] gdb: have gdb_disassemble_info carry 'this' in its stream pointer Andrew Burgess
2022-06-17 10:36 ` [PATCH 2/2] gdb: add support for disassembler styling using libopcodes Andrew Burgess
2022-06-17 11:16   ` Eli Zaretskii
2022-06-30 12:22     ` Andrew Burgess
2022-06-30 13:46       ` Eli Zaretskii
2022-07-04 10:15         ` Andrew Burgess
2022-07-20  2:09   ` Simon Marchi
2022-07-20 13:14     ` Andrew Burgess [this message]
2022-07-20 13:14       ` [PATCH 1/2] gdb: fix use of uninitialised gdb_printing_disassembler::m_in_comment Andrew Burgess
2022-07-20 14:21         ` Simon Marchi
2022-07-20 13:14       ` [PATCH 2/2] gdb/python: fix invalid use disassemble_info::stream Andrew Burgess
2022-07-25 18:27       ` [PATCH 0/2] Fix some undefined haviour bugs in Python disassembler API Andrew Burgess
2022-07-04 10:17 ` [PATCH 0/2] Use libopcodes disassembler styling with GDB Andrew Burgess
2022-07-11 14:18   ` Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1658322626.git.aburgess@redhat.com \
    --to=aburgess@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).