From: Andrew Burgess <aburgess@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] gdb: add support for disassembler styling using libopcodes
Date: Mon, 04 Jul 2022 11:15:15 +0100 [thread overview]
Message-ID: <87tu7xb2vg.fsf@redhat.com> (raw)
In-Reply-To: <831qv65knj.fsf@gnu.org>
Eli Zaretskii via Gdb-patches <gdb-patches@sourceware.org> writes:
>> From: Andrew Burgess <aburgess@redhat.com>
>> Cc: gdb-patches@sourceware.org
>> Date: Thu, 30 Jun 2022 13:22:27 +0100
>>
>> Thanks for your feedback. The updated patch below I believe addresses
>> all these issues.
>
> It does, thanks. One last nit:
>
>> + disasm_mnemonic_style.add_setshow_commands (no_class, _("\
>> +Disassembler mnemonic display styling.\n\
>> +Configure the colors and display intensity for instruction mnemonics\n\
>> +in the disassembler output. The \"disassembler mnemonic\" style is\n\
>> +used to displaying instruction mnemonics as well as any assembler\n\
> ^^^^^^^^^^^^^
> Either "to display" or "for displaying".
Thanks. This fix will be included in the final version of this patch.
Andrew
next prev parent reply other threads:[~2022-07-04 10:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-17 10:36 [PATCH 0/2] Use libopcodes disassembler styling with GDB Andrew Burgess
2022-06-17 10:36 ` [PATCH 1/2] gdb: have gdb_disassemble_info carry 'this' in its stream pointer Andrew Burgess
2022-06-17 10:36 ` [PATCH 2/2] gdb: add support for disassembler styling using libopcodes Andrew Burgess
2022-06-17 11:16 ` Eli Zaretskii
2022-06-30 12:22 ` Andrew Burgess
2022-06-30 13:46 ` Eli Zaretskii
2022-07-04 10:15 ` Andrew Burgess [this message]
2022-07-20 2:09 ` Simon Marchi
2022-07-20 13:14 ` [PATCH 0/2] Fix some undefined haviour bugs in Python disassembler API Andrew Burgess
2022-07-20 13:14 ` [PATCH 1/2] gdb: fix use of uninitialised gdb_printing_disassembler::m_in_comment Andrew Burgess
2022-07-20 14:21 ` Simon Marchi
2022-07-20 13:14 ` [PATCH 2/2] gdb/python: fix invalid use disassemble_info::stream Andrew Burgess
2022-07-25 18:27 ` [PATCH 0/2] Fix some undefined haviour bugs in Python disassembler API Andrew Burgess
2022-07-04 10:17 ` [PATCH 0/2] Use libopcodes disassembler styling with GDB Andrew Burgess
2022-07-11 14:18 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tu7xb2vg.fsf@redhat.com \
--to=aburgess@redhat.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).