public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Andrew Burgess <aburgess@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/3] gdb: add infcall specific debugging
Date: Thu, 06 Oct 2022 20:32:35 +0300	[thread overview]
Message-ID: <83bkqoq2mk.fsf@gnu.org> (raw)
In-Reply-To: <9871275a989ff2c262ea9c94e3172c7eabfe7957.1665076921.git.aburgess@redhat.com> (message from Andrew Burgess via Gdb-patches on Thu, 6 Oct 2022 18:23:45 +0100)

> Date: Thu,  6 Oct 2022 18:23:45 +0100
> From: Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>
> 
> diff --git a/gdb/NEWS b/gdb/NEWS
> index 796a4ef8072..8b519a648f7 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -111,6 +111,10 @@ maintenance print frame-id [ LEVEL ]
>    Print GDB's internal frame-id for the frame at LEVEL.  If LEVEL is
>    not given, then print the frame-id for the currently selected frame.
>  
> +set debug infcall on|off
> +show debug infcall
> +  Print additional debug messages about inferior function calls.
> +

This part is OK.

> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -27587,6 +27587,13 @@
>  @item show debug infrun
>  Displays the current state of @value{GDBN} inferior debugging.
>  
> +@item set debug infcall
> +@cindex inferior function call debugging info
> +Turns on or off display of debugging info related to when @value{GDBN}
> +makes inferior function calls.

Is the "related to when" part accurate?  It seems to imply that we
only display indications of such calls, whereas the code seems to do
much more: it shows detailed information about the call and its
results.  So maybe reword as follows:

  Turns on or off display of debugging info related to inferior
  function calls made by @value{GDBN}.

Thanks.

  reply	other threads:[~2022-10-06 17:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-06 17:23 [PATCH 0/3] Another set of debug output patches Andrew Burgess
2022-10-06 17:23 ` [PATCH 1/3] gdb: improve infrun_debug_show_threads output Andrew Burgess
2022-10-06 17:23 ` [PATCH 2/3] gdb: extra debug output in thread.c Andrew Burgess
2022-10-06 17:23 ` [PATCH 3/3] gdb: add infcall specific debugging Andrew Burgess
2022-10-06 17:32   ` Eli Zaretskii [this message]
2022-10-10 12:05     ` Andrew Burgess
2022-10-07 19:11 ` [PATCH 0/3] Another set of debug output patches Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83bkqoq2mk.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=aburgess@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).