Re: [PATCH 3/3] gdb: add infcall specific debugging

[Andrew Burgess <aburgess@redhat.com>]

Eli Zaretskii <eliz@gnu.org> writes:

>> Date: Thu,  6 Oct 2022 18:23:45 +0100
>> From: Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>
>> 
>> diff --git a/gdb/NEWS b/gdb/NEWS
>> index 796a4ef8072..8b519a648f7 100644
>> --- a/gdb/NEWS
>> +++ b/gdb/NEWS
>> @@ -111,6 +111,10 @@ maintenance print frame-id [ LEVEL ]
>>    Print GDB's internal frame-id for the frame at LEVEL.  If LEVEL is
>>    not given, then print the frame-id for the currently selected frame.
>>  
>> +set debug infcall on|off
>> +show debug infcall
>> +  Print additional debug messages about inferior function calls.
>> +
>
> This part is OK.
>
>> --- a/gdb/doc/gdb.texinfo
>> +++ b/gdb/doc/gdb.texinfo
>> @@ -27587,6 +27587,13 @@
>>  @item show debug infrun
>>  Displays the current state of @value{GDBN} inferior debugging.
>>  
>> +@item set debug infcall
>> +@cindex inferior function call debugging info
>> +Turns on or off display of debugging info related to when @value{GDBN}
>> +makes inferior function calls.
>
> Is the "related to when" part accurate?  It seems to imply that we
> only display indications of such calls, whereas the code seems to do
> much more: it shows detailed information about the call and its
> results.  So maybe reword as follows:
>
>   Turns on or off display of debugging info related to inferior
>   function calls made by @value{GDBN}.

Thanks for the feedback.  I pushed this series with the fix you
suggested.

Thanks,
Andrew